cc: Added RED_8 to the ResourceFormat enum

cc: Added RED_8 to the ResourceFormat enum

New ResourceFormat, RED_8, which translates to GL_UNSIGNED_BYTE on format
GL_RED_EXT.  This will be used during YUV playback.

At the moment nothing uses it.

BUG=435379
Committed: https://crrev.com/7550d17cfdab5d173f37e5b58cbd2cfeef3d0ed0
Cr-Commit-Position: refs/heads/master@{#306383}

Committed: https://crrev.com/14a2880db155e324efb8874ea57893cd86f3d83c
Cr-Commit-Position: refs/heads/master@{#306408}

[hendrikw, 2014-11-26 20:06:28]

hendrikw@chromium.org changed reviewers:
+ vmpstr@chromium.org

[hendrikw, 2014-11-26 20:07:28]

cc side changes for YUV using GL_RED_EXT instead of GL_LUMINANCE.

[danakj, 2014-11-26 20:13:52]

danakj@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2014-11-26 20:13:53]

https://codereview.chromium.org/735493003/diff/1/cc/resources/resource_format.h
File cc/resources/resource_format.h (right):

https://codereview.chromium.org/735493003/diff/1/cc/resources/resource_format...
cc/resources/resource_format.h:22: RED_8,
This makes the 3rd way to say it's a single byte. I assume this makes more sense
to people more familiar with open gl format things. But please confirm :)

[hendrikw, 2014-11-26 20:15:36]

On 2014/11/26 20:13:53, danakj wrote:
>
https://codereview.chromium.org/735493003/diff/1/cc/resources/resource_format.h
> File cc/resources/resource_format.h (right):
> 
>
https://codereview.chromium.org/735493003/diff/1/cc/resources/resource_format...
> cc/resources/resource_format.h:22: RED_8,
> This makes the 3rd way to say it's a single byte. I assume this makes more
sense
> to people more familiar with open gl format things. But please confirm :)

GL_LUMINANCE doesn't translate to direct 3d.  Please see the bug.

We still must support both because some systems do not support GL_EXT_texture_rg
(e.g. android).

[danakj, 2014-11-26 20:16:43]

OIC cool thanks.

[vmpstr, 2014-11-26 21:23:37]

lgtm from the code perspective, but +reveman as well, just in case.

[vmpstr, 2014-11-26 21:23:45]

vmpstr@chromium.org changed reviewers:
+ reveman@chromium.org

[reveman, 2014-11-27 04:07:09]

lgtm but I prefer if we wait to land this until we have a patch that will use
it.

https://codereview.chromium.org/735493003/diff/1/cc/resources/texture_uploade...
File cc/resources/texture_uploader_unittest.cc (right):

https://codereview.chromium.org/735493003/diff/1/cc/resources/texture_uploade...
cc/resources/texture_uploader_unittest.cc:118: case GL_RG_EXT:
nit: are we using GL_RG_EXT? please remove if not used.

[hendrikw, 2014-12-02 13:23:45]

The CQ bit was checked by hendrikw@chromium.org

[commit-bot: I haz the power, 2014-12-02 13:24:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/735493003/20001

[commit-bot: I haz the power, 2014-12-02 14:24:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-02 14:25:23]

Patchset 2 (id:??) landed as
https://crrev.com/7550d17cfdab5d173f37e5b58cbd2cfeef3d0ed0
Cr-Commit-Position: refs/heads/master@{#306383}

[pkotwicz, 2014-12-02 15:12:10]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/775663002/ by pkotwicz@chromium.org.

The reason for reverting is: Reverting the CL because it broke the CrOS ozone
compile. See
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2....

[hendrikw, 2014-12-02 15:41:14]

On 2014/12/02 15:12:10, pkotwicz wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/775663002/ by mailto:pkotwicz@chromium.org.
> 
> The reason for reverting is: Reverting the CL because it broke the CrOS ozone
> compile. See
>
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2....

Now I know what NOTREACHED does :)

I've added the missing case, PTAL

[danakj, 2014-12-02 16:14:46]

c/b/compositor LGTM

[hendrikw, 2014-12-02 16:22:00]

The CQ bit was checked by hendrikw@chromium.org

[commit-bot: I haz the power, 2014-12-02 16:22:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/735493003/60001

[commit-bot: I haz the power, 2014-12-02 17:23:22]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-12-02 17:24:07]

Patchset 4 (id:??) landed as
https://crrev.com/14a2880db155e324efb8874ea57893cd86f3d83c
Cr-Commit-Position: refs/heads/master@{#306408}