Rename app_modal_dialogs dir to app_modal

components/app_modal.gypi

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 {
   'targets': [
     {
-      'target_name': 'app_modal_dialogs',
+      'target_name': 'app_modal',
       'type': 'static_library',
       'dependencies': [
         '../content/content.gyp:content_browser',
         '../content/content.gyp:content_common',
         '../skia/skia.gyp:skia',
         'components_strings.gyp:components_strings',
       ],
       'include_dirs': [
         '..',
       ],
       'sources': [
-        'app_modal_dialogs/app_modal_dialog.cc',
-        'app_modal_dialogs/app_modal_dialog.h',
-        'app_modal_dialogs/app_modal_dialog_queue.cc',
-        'app_modal_dialogs/app_modal_dialog_queue.h',
-        'app_modal_dialogs/app_modal_dialog_test_util.h',

[msw, 2014/11/17 19:14:41]

Good catch... I wonder how this file got deleted but not these entries.

[oshima, 2014/11/17 21:40:23]

AFAIK, build system doesn't check the existence of file
unless it's required to build stuff (like .cc).

It'd be nice to have presubmit warning though.

-        'app_modal_dialogs/javascript_app_modal_dialog.cc',
-        'app_modal_dialogs/javascript_app_modal_dialog.h',
-        'app_modal_dialogs/javascript_dialog_extensions_client.h',
-        'app_modal_dialogs/javascript_dialog_manager.cc',
-        'app_modal_dialogs/javascript_dialog_manager.h',
-        'app_modal_dialogs/javascript_dialog_manager_impl.cc',
-        'app_modal_dialogs/javascript_dialog_manager_impl.h',
-        'app_modal_dialogs/javascript_native_dialog_factory.h',
-        'app_modal_dialogs/native_app_modal_dialog.h'
+        'app_modal/app_modal_dialog.cc',
+        'app_modal/app_modal_dialog.h',
+        'app_modal/app_modal_dialog_queue.cc',
+        'app_modal/app_modal_dialog_queue.h',
+        'app_modal/javascript_app_modal_dialog.cc',
+        'app_modal/javascript_app_modal_dialog.h',
+        'app_modal/javascript_dialog_extensions_client.h',
+        'app_modal/javascript_dialog_manager.cc',
+        'app_modal/javascript_dialog_manager.h',
+        'app_modal/javascript_dialog_manager_impl.cc',
+        'app_modal/javascript_dialog_manager_impl.h',
+        'app_modal/javascript_native_dialog_factory.h',
+        'app_modal/native_app_modal_dialog.h'
       ],
       'conditions': [
         ['use_aura==1',{
           'dependencies': [
             '../ui/aura/aura.gyp:aura',
           ],
         }],
         ['toolkit_views==1 and OS!="mac"', {
           'sources': [
-            'app_modal_dialogs/views/javascript_app_modal_dialog_views.h',
-            'app_modal_dialogs/views/javascript_app_modal_dialog_views.cc',
+            'app_modal/views/javascript_app_modal_dialog_views.h',
+            'app_modal/views/javascript_app_modal_dialog_views.cc',
           ],
         }],
       ],
     },
   ],
 }