Issue 735463004: Remove --v arg from mojo_shell, it appears to no longer be valid.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 735463004: Remove --v arg from mojo_shell, it appears to no longer be valid.

Created:
6 years, 1 month ago by eseidel

Modified:
6 years, 1 month ago

Reviewers:
DaveMoore

CC:
mojo-reviews_chromium.org, ojan, esprehn, abarth-chromium, aa

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Remove --v arg from mojo_shell, it appears to no longer be valid. Looks like this was broken by: https://codereview.chromium.org/731923002/

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	sky/tools/skydb	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

DaveMoore

On 2014/11/17 19:30:57, eseidel wrote: Sounds like my recent change to be strict about args ...

6 years, 1 month ago (2014-11-17 20:18:44 UTC) #6

viettrungluu

6 years, 1 month ago (2014-11-17 20:37:01 UTC) #7

On 2014/11/17 20:18:44, DaveMoore wrote:
> On 2014/11/17 19:30:57, eseidel wrote:
> 
> Sounds like my recent change to be strict about args to mojo_shell broke this.
> Don't submit this, I'll add it to the checking.

Don't forget --vmodule either.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages