Source/modules/websockets/WebSocketChannelClient.h - Issue 735433002: DOMWebSocket::bufferedAmount() should not return an "unsigned long"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/websockets/WebSocketChannelClient.h

Issue 735433002: DOMWebSocket::bufferedAmount() should not return an "unsigned long" (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/websockets/DocumentWebSocketChannelTest.cpp ('k') | Source/modules/websockets/WorkerWebSocketChannel.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/websockets/WebSocketChannelClient.h

diff --git a/Source/modules/websockets/WebSocketChannelClient.h b/Source/modules/websockets/WebSocketChannelClient.h

index 82b455c112a6c4424695cd31b7e50bc9fe46382f..bf86101ae3aa6dc82006ecd55875230efc568b9e 100644

--- a/Source/modules/websockets/WebSocketChannelClient.h

+++ b/Source/modules/websockets/WebSocketChannelClient.h

@@ -45,7 +45,7 @@ public:

virtual void didReceiveTextMessage(const String&) { }

virtual void didReceiveBinaryMessage(PassOwnPtr<Vector<char> >) { }

virtual void didError() { }

- virtual void didConsumeBufferedAmount(unsigned long consumed) { }

+ virtual void didConsumeBufferedAmount(unsigned consumed) { }

virtual void didStartClosingHandshake() { }

enum ClosingHandshakeCompletionStatus {

ClosingHandshakeIncomplete,

« no previous file with comments | « Source/modules/websockets/DocumentWebSocketChannelTest.cpp ('k') | Source/modules/websockets/WorkerWebSocketChannel.h » ('j') | no next file with comments »