Issue 735423002: clang/win: Fix 2 new -Wwritable-strings warnings.

Issue 735423002: clang/win: Fix 2 new -Wwritable-strings warnings. (Closed)

Created:
6 years, 1 month ago by Nico

Modified:
6 years, 1 month ago

Reviewers:
pauljensen, guoweis_left_chromium, guoweis2

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

clang/win: Fix 2 new -Wwritable-strings warnings. MSDN says "This member is read only", so just casting is fine. BUG=82385 Committed: https://crrev.com/cdc61efc53d7bd5977376cdf1270c2ece896243c Cr-Commit-Position: refs/heads/master@{#305016}

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	net/base/net_util_unittest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 9 (3 generated)

guoweis2

On 2014/11/19 21:12:52, Nico wrote: lgtm, +pauljensen for OWNER review.

6 years, 1 month ago (2014-11-19 22:09:03 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/735423002/1

6 years, 1 month ago (2014-11-20 14:38:50 UTC) #7

commit-bot: I haz the power

6 years, 1 month ago (2014-11-20 15:22:30 UTC) #9

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/cdc61efc53d7bd5977376cdf1270c2ece896243c
Cr-Commit-Position: refs/heads/master@{#305016}