Issue 73533002: Remove the Views bubble double widget hack.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 73533002: Remove the Views bubble double widget hack. (Closed)

Created:
7 years, 1 month ago by msw

Modified:
7 years, 1 month ago

Reviewers:
sky

CC:
chromium-reviews, msw+watch_chromium.org, alicet1, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove the Views bubble double widget hack. Views bubbles had a hack to use two separate widgets. The border widget supported per-pixel alpha for edge images. The content widget supported native windows textfields, etc. This isn't needed after win textfield removal in r235220. Remove BubbleBorderDelegate and the border widget code. Remove BubbleDelegateView::GetBubbleClientBounds Remove BubbleBorder::client_bounds and usage. (was used to clip intersecting widget area during fade) BUG=131660 TEST=No visual difference, no regressions (I tested that bubbles still work on a local non-Aura Win build too). R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235715

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -165 lines)			Patch
M	ui/views/bubble/bubble_border.h	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	ui/views/bubble/bubble_border.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	ui/views/bubble/bubble_delegate.h	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	ui/views/bubble/bubble_delegate.cc	View	10 chunks	+8 lines, -143 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/73533002/1

7 years, 1 month ago (2013-11-15 22:33:28 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/73533002/1

7 years, 1 month ago (2013-11-16 01:28:06 UTC) #4

Message was sent while issue was closed.

Change committed as 235715

Expand Messages | Collapse Messages