Issue 735323002: Revert "Re-land r25392 Use a stub in crankshaft for grow store arrays."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 735323002: Revert "Re-land r25392 Use a stub in crankshaft for grow store arrays." (Closed)

Created:
6 years, 1 month ago by mvstanton

Modified:
6 years, 1 month ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

More Reviews

Description

Revert "Re-land r25392 Use a stub in crankshaft for grow store arrays." Due to performance issue. TBR=danno@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/cfa1f947812c6112c73ede06c8dcb842638860e0

Patch Set 1 #

Patch Set 2 : Ports. #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -352 lines)			Patch
M	src/arm/interface-descriptors-arm.cc	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View		1 chunk	+2 lines, -6 lines	0 comments	Download
M	src/arm64/interface-descriptors-arm64.cc	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/code-stubs.h	View		2 chunks	+0 lines, -24 lines	0 comments	Download
M	src/code-stubs.cc	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/code-stubs-hydrogen.cc	View		1 chunk	+0 lines, -25 lines	0 comments	Download
M	src/hydrogen.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/hydrogen.cc	View		2 chunks	+10 lines, -34 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View		3 chunks	+1 line, -4 lines	0 comments	Download
M	src/ia32/interface-descriptors-ia32.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/interface-descriptors.h	View		2 chunks	+1 line, -13 lines	0 comments	Download
M	src/interface-descriptors.cc	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/mips/interface-descriptors-mips.cc	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/mips64/interface-descriptors-mips64.cc	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/objects.h	View		3 chunks	+5 lines, -10 lines	0 comments	Download
M	src/objects.cc	View		5 chunks	+10 lines, -24 lines	0 comments	Download
M	src/objects-inl.h	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/runtime/runtime.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/runtime/runtime-array.cc	View		1 chunk	+0 lines, -38 lines	0 comments	Download
M	src/x64/interface-descriptors-x64.cc	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/x87/interface-descriptors-x87.cc	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download
D	test/mjsunit/ensure-growing-store-learns.js	View		1 chunk	+0 lines, -109 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

mvstanton

6 years, 1 month ago (2014-11-19 14:08:49 UTC) #1

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
cfa1f947812c6112c73ede06c8dcb842638860e0 (presubmit successful).

Expand Messages | Collapse Messages