Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 735293005: Push API: delete the old layout tests [switchover 1/6] (Closed)

Created:
6 years ago by Michael van Ouwerkerk
Modified:
6 years ago
Reviewers:
Peter Beverloo
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Push API: delete the old layout tests [switchover 1/6] These layout tests exercise the API in its old form which is about to change. To make future changes easier to land, these tests are deleted first. This patch has no dependencies. This part 1 of a series of 6 patches. See https://crbug.com/440076 for the plan to land them. BUG=389194, 440076 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186885

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -263 lines) Patch
D LayoutTests/push_messaging/push-messaging.html View 1 chunk +0 lines, -54 lines 0 comments Download
D LayoutTests/push_messaging/push-messaging-api-surface.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/push_messaging/push-messaging-api-surface-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/push_messaging/push-messaging-detached-no-crash.html View 1 chunk +0 lines, -40 lines 0 comments Download
D LayoutTests/push_messaging/push-messaging-detached-no-crash-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/push_messaging/push-messaging-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/push_messaging/push-messaging-has-permission.html View 1 chunk +0 lines, -48 lines 0 comments Download
D LayoutTests/push_messaging/push-messaging-has-permission-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/push_messaging/push-messaging-resolve-after-detached.html View 1 chunk +0 lines, -28 lines 0 comments Download
D LayoutTests/push_messaging/push-messaging-resolve-after-detached-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/push_messaging/resources/push-messaging-detached-no-crash-new-window.html View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/push_messaging/resources/push-messaging-resolve-after-detached.html View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael van Ouwerkerk
Peter, could you take a look please?
6 years ago (2014-12-08 20:03:23 UTC) #2
Peter Beverloo
On 2014/12/08 20:03:23, Michael van Ouwerkerk wrote: > Peter, could you take a look please? ...
6 years ago (2014-12-08 20:41:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/735293005/1
6 years ago (2014-12-10 22:00:53 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-10 22:29:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186885

Powered by Google App Engine
This is Rietveld 408576698