Issue 735293004: [turbofan]: Use "leal" more prevasively on x64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 735293004: [turbofan]: Use "leal" more prevasively on x64 (Closed)

Created:
6 years ago by danno

Modified:
6 years ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

More Reviews

Description

[turbofan]: Use "leal" more prevasively on x64 Only use "addl" and "subl" in cases that have been measured to be faster (currently only immediate operations).

Patch Set 1 #

Patch Set 2 : Iterate #

Patch Set 3 : Fix comments #

Patch Set 4 : Tweaks #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -54 lines)			Patch
M	src/compiler/x64/code-generator-x64.cc	View	1 2	1 chunk	+18 lines, -2 lines	0 comments	Download
M	src/compiler/x64/instruction-selector-x64.cc	View		2 chunks	+6 lines, -36 lines	0 comments	Download
M	test/unittests/compiler/x64/instruction-selector-x64-unittest.cc	View	1 2 3	6 chunks	+31 lines, -16 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/735293004/60001

6 years ago (2014-12-01 09:36:59 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 (id:60001)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages