Remove the assumption that test_pdf.cc is not sandboxed.

Because the test is sandboxed, it cannot call LoadV8Snapshot(). For the same reason, LoadV8Snapshot() must have been called in PreInitializeSandbox(), so the asserts are still valid.

BUG=421063
Committed: https://crrev.com/e0021151b12cd4189f678f26fed8ad2962d12db9
Cr-Commit-Position: refs/heads/master@{#305000}

[baixo1, 2014-11-19 11:53:39]

Patchset #2 (id:20001) has been deleted

[baixo1, 2014-11-19 11:58:20]

baixo@google.com changed reviewers:
+ baixo@google.com, raymes@chromium.org, rmcilroy@chromium.org

[baixo1, 2014-11-19 11:58:20]

Because test_pdf.cc is sandboxed, LoadV8Snapshot() cannot be called. For the
same reason, LoadV8Snapshot() must have been called in PreInitializeSandbox().
Therefore we can just check whether the return values of
GetV8ExternalSnapshotData() are NULL/0 or not.

Because we no longer need to call LoadV8Snapshot() in tests, the gin dependency
can be removed from DEPS and GYP.

[rmcilroy, 2014-11-19 13:57:59]

On 2014/11/19 11:58:20, baixo1 wrote:
> Because test_pdf.cc is sandboxed, LoadV8Snapshot() cannot be called. For the
> same reason, LoadV8Snapshot() must have been called in PreInitializeSandbox().
> Therefore we can just check whether the return values of
> GetV8ExternalSnapshotData() are NULL/0 or not.
> 
> Because we no longer need to call LoadV8Snapshot() in tests, the gin
dependency
> can be removed from DEPS and GYP.

lgtm, thanks.

[raymes, 2014-11-20 07:36:09]

lgtm

[baixo1, 2014-11-20 09:43:17]

The CQ bit was checked by baixo@google.com

[commit-bot: I haz the power, 2014-11-20 09:43:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/735283002/1

[commit-bot: I haz the power, 2014-11-20 10:47:35]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-11-20 10:48:08]

Patchset 1 (id:??) landed as
https://crrev.com/e0021151b12cd4189f678f26fed8ad2962d12db9
Cr-Commit-Position: refs/heads/master@{#305000}