Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 735263002: Oilpan: remove GC plugin ignore for recursive value objects. (Closed)

Created:
6 years, 1 month ago by sof
Modified:
6 years ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Oilpan: remove GC plugin ignore for recursive value objects. The GC_PLUGIN_IGNORE() is no longer needed as clang rolls now includes http://crbug.com/424962 R=kouhei,haraken BUG=424962 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187276

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M Source/core/inspector/DevToolsHost.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
sof
Please take a look. clang roll based on 223108 appears to have settled, so this ...
6 years ago (2014-12-16 12:36:51 UTC) #2
kouhei (in TOK)
lgtm % trybots are green
6 years ago (2014-12-16 13:29:47 UTC) #4
haraken
LGTM
6 years ago (2014-12-16 13:46:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/735263002/1
6 years ago (2014-12-16 14:08:32 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/42056)
6 years ago (2014-12-16 15:44:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/735263002/1
6 years ago (2014-12-16 16:11:45 UTC) #11
commit-bot: I haz the power
6 years ago (2014-12-16 17:27:49 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187276

Powered by Google App Engine
This is Rietveld 408576698