Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 735233003: SkCanvas::clear() should call down to devices even when the clip is empty. (Closed)

Created:
6 years, 1 month ago by mtklein_C
Modified:
6 years, 1 month ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org, humper
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

SkCanvas::clear() should call down to devices even when the clip is empty. SkDrawIter had a lovely, completely unused, option for this. Oversight? BUG=skia: Committed: https://skia.googlesource.com/skia/+/378e70d8e561b72a904286ea231946f5c8345b9a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M src/core/SkCanvas.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/CanvasTest.cpp View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/735233003/1
6 years, 1 month ago (2014-11-19 17:23:48 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-19 17:23:49 UTC) #3
mtklein_C
6 years, 1 month ago (2014-11-19 17:28:17 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
6 years, 1 month ago (2014-11-19 23:23:50 UTC) #7
reed1
lgtm
6 years, 1 month ago (2014-11-20 16:53:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/735233003/1
6 years, 1 month ago (2014-11-20 16:57:55 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/378e70d8e561b72a904286ea231946f5c8345b9a
6 years, 1 month ago (2014-11-20 16:58:08 UTC) #11
f(malita)
On 2014/11/20 16:58:08, I haz the power (commit-bot) wrote: > Committed patchset #1 (id:1) as ...
6 years, 1 month ago (2014-11-21 04:40:53 UTC) #12
f(malita)
6 years, 1 month ago (2014-11-21 04:43:02 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/748733002/ by fmalita@chromium.org.

The reason for reverting is: Chrome unit_tests failures on Mac & Win, blocking
the roll:
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_....

Powered by Google App Engine
This is Rietveld 408576698