Fix windowed NPAPI plugins appearing under dialogs when DWM compositing is disabled and the tab swi…

Fix windowed NPAPI plugins appearing under dialogs when DWM compositing is disabled and the tab switches back and forth.

I fixed the one-tab case in r234823, but while testing I found that if I switched to another tab and and came back, then the fix stopped working. The bug was that when the root window became the parent, the next time the parent window changed we stopped observing the parent window, but never observed the root window again.

BUG=299224
R=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235305

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235329

[Ben Goodger (Google), 2013-11-15 03:05:37]

this all seems really brittle. at some point I should sit down and understand
all of this but for now lgtm.

[jam, 2013-11-15 17:43:52]

On 2013/11/15 03:05:37, Ben Goodger (Google) wrote:
> this all seems really brittle. at some point I should sit down and understand
> all of this but for now lgtm.

at this point it's probably simpler to just always be watching all the windows.
rharisson has a change to do that for other reasons.

[Ben Goodger (Google), 2013-11-15 17:46:38]

I agree with this.

-Ben


On Fri, Nov 15, 2013 at 9:43 AM, <jam@chromium.org> wrote:

> On 2013/11/15 03:05:37, Ben Goodger (Google) wrote:
>
>> this all seems really brittle. at some point I should sit down and
>> understand
>> all of this but for now lgtm.
>>
>
> at this point it's probably simpler to just always be watching all the
> windows.
> rharisson has a change to do that for other reasons.
>
> https://codereview.chromium.org/73523002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.