Add guard pages in front of platform allocations

src/platform-linux.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 352 matching lines @@
   return sysconf(_SC_PAGESIZE);
 }
 
 
 void* OS::Allocate(const size_t requested,
                    size_t* allocated,
                    bool is_executable) {
   // TODO(805): Port randomization of allocated executable memory to Linux.
   const size_t msize = RoundUp(requested, sysconf(_SC_PAGESIZE));
   int prot = PROT_READ | PROT_WRITE | (is_executable ? PROT_EXEC : 0);
-  void* mbase = mmap(NULL, msize, prot, MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
+  void* mbase = mmap(NULL, msize + Page::kPageSize, prot,

[Vyacheslav Egorov (Chromium), 2011/07/12 23:23:29]

V8 uses "one argument per line" convention.

[Cris Neckar, 2011/07/14 17:32:28]

Done.

+                     MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
   if (mbase == MAP_FAILED) {
     LOG(i::Isolate::Current(),
         StringEvent("OS::Allocate", "mmap failed"));
     return NULL;
   }
   *allocated = msize;
+  mprotect(mbase, Page::kPageSize, PROT_NONE);
+  mbase += Page::kPageSize;

[Vyacheslav Egorov (Chromium), 2011/07/12 23:23:29]

I am a bit concerned that we are spreading (and duplicating) guard page
management across platform-* files instead of managing it uniformly in the
MemoryAllocator which seems more appropriate place to me (OS::* should be just a
low-level OS interface).

[Cris Neckar, 2011/07/14 17:32:28]

Done.

   UpdateAllocatedSpaceLimits(mbase, msize);
   return mbase;
 }
 
 
 void OS::Free(void* address, const size_t size) {
   // TODO(1240712): munmap has a return value which is ignored here.
-  int result = munmap(address, size);
+  int result = munmap(address - Page::kPageSize, size + Page::kPageSize);
   USE(result);
   ASSERT(result == 0);
 }
 
 
 #ifdef ENABLE_HEAP_PROTECTION
 
 void OS::Protect(void* address, size_t size) {
   // TODO(1240712): mprotect has a return value which is ignored here.
   mprotect(address, size, PROT_READ);
@@ skipping 746 matching lines @@
 
 void Sampler::Stop() {
   ASSERT(IsActive());
   SignalSender::RemoveActiveSampler(this);
   SetActive(false);
 }
 
 #endif  // ENABLE_LOGGING_AND_PROFILING
 
 } }  // namespace v8::internal