Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Issue 735173003: Add ES3 APIs to gl bindings: PART II. (Closed)

Created:
6 years, 1 month ago by Zhenyao Mo
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@binding
Project:
chromium
Visibility:
Public.

Description

Add ES3 APIs to gl bindings: PART II. This is the second half of the new APIs. BUG=429052 TEST=bots R=kbr@chromium.org Committed: https://crrev.com/810a8a7bf37bafbe610f9710d2c07167a0410110 Cr-Commit-Position: refs/heads/master@{#304950}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -9 lines) Patch
M ui/gl/generate_bindings.py View 1 2 22 chunks +172 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Zhenyao Mo
kbr: please review. This completes all the ES3 APIs.
6 years, 1 month ago (2014-11-19 23:04:54 UTC) #2
Ken Russell (switch to Gerrit)
Very very nice. LGTM
6 years, 1 month ago (2014-11-20 00:08:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/735173003/60001
6 years, 1 month ago (2014-11-20 00:14:58 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:60001)
6 years, 1 month ago (2014-11-20 01:11:25 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 01:12:09 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/810a8a7bf37bafbe610f9710d2c07167a0410110
Cr-Commit-Position: refs/heads/master@{#304950}

Powered by Google App Engine
This is Rietveld 408576698