Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 735153002: Add processor name to comment when printing out shaders. (Closed)

Created:
6 years, 1 month ago by egdaniel
Modified:
6 years, 1 month ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add processor name to comment when printing out shaders. BUG=skia: Committed: https://skia.googlesource.com/skia/+/ec03a4608025106ea3f21353865c7d302c0a13c6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M include/gpu/GrProcessorStage.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
egdaniel
6 years, 1 month ago (2014-11-18 21:10:16 UTC) #2
joshualitt
On 2014/11/18 21:10:16, egdaniel wrote: lgtm
6 years, 1 month ago (2014-11-18 21:10:48 UTC) #3
bsalomon
lgtm
6 years, 1 month ago (2014-11-18 21:47:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/735153002/1
6 years, 1 month ago (2014-11-19 14:14:32 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 14:22:44 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ec03a4608025106ea3f21353865c7d302c0a13c6

Powered by Google App Engine
This is Rietveld 408576698