Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issue 735053002: Prefix CommandLine usage with base namespace (Part 7: cloud_print/) (Closed)

Created:
6 years, 1 month ago by elecro
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Prefix CommandLine usage with base namespace (Part 7: cloud_print/) Prefix all CommandLine usage in the cloud_print/ directory with the base:: namespace. R=vitalybuka@chromium.org BUG=422426 Committed: https://crrev.com/588a3ead6ef36c3ccb9dd51dd028c251a4fb511b Cr-Commit-Position: refs/heads/master@{#304744}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -43 lines) Patch
M cloud_print/common/win/install_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cloud_print/gcp20/prototype/command_line_reader.cc View 5 chunks +8 lines, -6 lines 0 comments Download
M cloud_print/gcp20/prototype/dns_sd_server.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M cloud_print/gcp20/prototype/gcp20_device.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M cloud_print/gcp20/prototype/print_job_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/gcp20/prototype/printer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cloud_print/gcp20/prototype/privet_http_server.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M cloud_print/service/win/chrome_launcher.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M cloud_print/service/win/cloud_print_service.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M cloud_print/service/win/cloud_print_service_config.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/service/win/installer.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M cloud_print/service/win/service_controller.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M cloud_print/service/win/service_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cloud_print/virtual_driver/win/install/setup.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M cloud_print/virtual_driver/win/port_monitor/port_monitor.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
elecro
Please take a look.
6 years, 1 month ago (2014-11-18 14:45:25 UTC) #2
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 1 month ago (2014-11-19 01:24:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/735053002/1
6 years, 1 month ago (2014-11-19 01:25:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-19 02:06:14 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 02:07:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/588a3ead6ef36c3ccb9dd51dd028c251a4fb511b
Cr-Commit-Position: refs/heads/master@{#304744}

Powered by Google App Engine
This is Rietveld 408576698