Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 735043002: Enable loading V8's initial snapshot from external files on Linux. (Closed)

Created:
6 years, 1 month ago by baixo
Modified:
6 years, 1 month ago
Reviewers:
baixo1, rmcilroy
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Enable loading V8's initial snapshot from external files on Linux. BUG=421063, 434985 Committed: https://crrev.com/85e17b910590a0da3ed71b5f44e55cba79ea990d Cr-Commit-Position: refs/heads/master@{#305007}

Patch Set 1 #

Patch Set 2 : Sync against master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
baixo1
6 years, 1 month ago (2014-11-18 14:12:51 UTC) #2
rmcilroy
On 2014/11/18 14:12:51, baixo1 wrote: lgtm
6 years, 1 month ago (2014-11-18 15:20:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/735043002/1
6 years, 1 month ago (2014-11-18 15:56:43 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/6710)
6 years, 1 month ago (2014-11-18 17:55:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/735043002/1
6 years, 1 month ago (2014-11-20 12:05:52 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/11608) linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/396) linux_chromium_chromeos_rel_ng ...
6 years, 1 month ago (2014-11-20 12:09:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/735043002/20001
6 years, 1 month ago (2014-11-20 12:21:15 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-20 13:43:07 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/85e17b910590a0da3ed71b5f44e55cba79ea990d Cr-Commit-Position: refs/heads/master@{#305007}
6 years, 1 month ago (2014-11-20 13:43:54 UTC) #15
rmcilroy
6 years, 1 month ago (2014-11-20 16:40:26 UTC) #16
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/740403002/ by rmcilroy@chromium.org.

The reason for reverting is: Breaking PrintPreviewWebUITest on linux bots.

BUG=435167,421063,434985.

Powered by Google App Engine
This is Rietveld 408576698