Move PDF to PWG conversion into PrivetLocalPrintOperationImpl

chrome/browser/local_discovery/privet_http_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/message_loop/message_loop.h"
 #include "chrome/browser/local_discovery/privet_http_impl.h"
 #include "net/base/host_port_pair.h"
 #include "net/base/net_errors.h"
 #include "net/url_request/test_url_fetcher_factory.h"
@@ skipping 361 matching lines @@
 
   MOCK_METHOD1(OnPrivetRegisterDoneInternal,
                void(const std::string& device_id));
 };
 
 class MockLocalPrintDelegate : public PrivetLocalPrintOperation::Delegate {
  public:
   MockLocalPrintDelegate() {}
   ~MockLocalPrintDelegate() {}
 
-  virtual void OnPrivetPrintingRequestPDF(
-      const PrivetLocalPrintOperation* print_operation) {
-    OnPrivetPrintingRequestPDFInternal();
-  }
-
-  MOCK_METHOD0(OnPrivetPrintingRequestPDFInternal, void());
-
-  virtual void OnPrivetPrintingRequestPWGRaster(
-      const PrivetLocalPrintOperation* print_operation) {
-    OnPrivetPrintingRequestPWGRasterInternal();
-  }
-
-  MOCK_METHOD0(OnPrivetPrintingRequestPWGRasterInternal, void());
-
   virtual void OnPrivetPrintingDone(
       const PrivetLocalPrintOperation* print_operation) {
     OnPrivetPrintingDoneInternal();
   }
 
   MOCK_METHOD0(OnPrivetPrintingDoneInternal, void());
 
   virtual void OnPrivetPrintingError(
       const PrivetLocalPrintOperation* print_operation, int http_code) {
     OnPrivetPrintingErrorInternal(http_code);
   }
 
   MOCK_METHOD1(OnPrivetPrintingErrorInternal, void(int http_code));
 };
 
+// A note on PWG raster conversion: The PWG raster converter used simply
+// converts strings to file paths based on them by appending "test.pdf", since
+// it's easier to test that way. Instead of using a mock, we simply check if the
+// request is uploading a file that is based on this pattern.
+class FakePWGRasterConverter : public PWGRasterConverter {
+ public:
+  FakePWGRasterConverter() {
+  }
+
+  virtual ~FakePWGRasterConverter() {
+  }
+
+  virtual void SetResultCallback(const ResultCallback& callback) OVERRIDE {
+    callback_ = callback;
+  }
+
+  virtual void SetPDFData(scoped_refptr<base::RefCountedBytes> data) OVERRIDE {
+    std::string data_str((const char*)data->front(), data->size());
+    data_ = data_str;
+  }
+
+  virtual void Start() OVERRIDE {
+    callback_.Run(true, base::FilePath(data_ + "test.pdf"));
+  }
+
+ private:
+  ResultCallback callback_;
+  std::string data_;
+};
+
+
 class PrivetInfoTest : public PrivetHTTPTest {
  public:
   PrivetInfoTest() {}
 
   virtual ~PrivetInfoTest() {}
 
   virtual void SetUp() OVERRIDE {
     info_operation_ = privet_client_->CreateInfoOperation(&info_delegate_);
   }
 
@@ skipping 354 matching lines @@
 
 class PrivetLocalPrintTest : public PrivetHTTPTest {
  public:
   PrivetLocalPrintTest() {}
 
   virtual ~PrivetLocalPrintTest() {}
 
   virtual void SetUp() OVERRIDE {
     local_print_operation_ = privet_client_->CreateLocalPrintOperation(
         &local_print_delegate_);
+
+    local_print_operation_->SetPWGRasterConverterForTesting(
+        scoped_ptr<PWGRasterConverter>(new FakePWGRasterConverter));
+  }
+
+  scoped_refptr<base::RefCountedBytes> RefCountedBytesFromString(
+      std::string str) {
+    std::vector<unsigned char> str_vec;
+    str_vec.insert(str_vec.begin(), str.begin(), str.end());
+    return scoped_refptr<base::RefCountedBytes>(
+        base::RefCountedBytes::TakeVector(&str_vec));
   }
 
  protected:
   scoped_ptr<PrivetLocalPrintOperation> local_print_operation_;
   StrictMock<MockLocalPrintDelegate> local_print_delegate_;
 };
 
 TEST_F(PrivetLocalPrintTest, SuccessfulLocalPrint) {
   local_print_operation_->SetUsername("sample@gmail.com");
   local_print_operation_->SetJobname("Sample job name");
+  local_print_operation_->SetData(RefCountedBytesFromString(
+      "Sample print data"));
   local_print_operation_->Start();
 
   EXPECT_TRUE(SuccessfulResponseToURL(
       GURL("http://10.0.0.8:6006/privet/info"),
       kSampleInfoResponse));
 
-  EXPECT_CALL(local_print_delegate_, OnPrivetPrintingRequestPDFInternal());
-
   EXPECT_TRUE(SuccessfulResponseToURL(
       GURL("http://10.0.0.8:6006/privet/capabilities"),
       kSampleCapabilitiesResponse));
 
-  local_print_operation_->SendData("Sample print data");
-
   EXPECT_CALL(local_print_delegate_, OnPrivetPrintingDoneInternal());
 
   // TODO(noamsml): Is encoding spaces as pluses standard?
   EXPECT_TRUE(SuccessfulResponseToURLAndData(
       GURL("http://10.0.0.8:6006/privet/printer/submitdoc?"
            "user=sample%40gmail.com&jobname=Sample+job+name"),
       "Sample print data",
       kSampleLocalPrintResponse));
 };
 
 TEST_F(PrivetLocalPrintTest, SuccessfulLocalPrintWithAnyMimetype) {
   local_print_operation_->SetUsername("sample@gmail.com");
   local_print_operation_->SetJobname("Sample job name");
+  local_print_operation_->SetData(RefCountedBytesFromString(

[Vitaly Buka (NO REVIEWS), 2013/11/15 06:48:38]

line break before RefCountedBytesFromString

[Noam Samuel, 2013/11/15 19:13:46]

Done.

+      "Sample print data"));
   local_print_operation_->Start();
 
   EXPECT_TRUE(SuccessfulResponseToURL(
       GURL("http://10.0.0.8:6006/privet/info"),
       kSampleInfoResponse));
 
-  EXPECT_CALL(local_print_delegate_, OnPrivetPrintingRequestPDFInternal());
-
   EXPECT_TRUE(SuccessfulResponseToURL(
       GURL("http://10.0.0.8:6006/privet/capabilities"),
       kSampleCapabilitiesResponseWithAnyMimetype));
 
-  local_print_operation_->SendData("Sample print data");
-
   EXPECT_CALL(local_print_delegate_, OnPrivetPrintingDoneInternal());
 
   // TODO(noamsml): Is encoding spaces as pluses standard?
   EXPECT_TRUE(SuccessfulResponseToURLAndData(
       GURL("http://10.0.0.8:6006/privet/printer/submitdoc?"
            "user=sample%40gmail.com&jobname=Sample+job+name"),
       "Sample print data",
       kSampleLocalPrintResponse));
 };
 
 TEST_F(PrivetLocalPrintTest, SuccessfulPWGLocalPrint) {
   local_print_operation_->SetUsername("sample@gmail.com");
   local_print_operation_->SetJobname("Sample job name");
+  local_print_operation_->SetData(RefCountedBytesFromString(

[Vitaly Buka (NO REVIEWS), 2013/11/15 06:48:38]

same

[Noam Samuel, 2013/11/15 19:13:46]

Done.

+      "path/to/"));
   local_print_operation_->Start();
 
   EXPECT_TRUE(SuccessfulResponseToURL(
       GURL("http://10.0.0.8:6006/privet/info"),
       kSampleInfoResponse));
 
-  EXPECT_CALL(local_print_delegate_,
-              OnPrivetPrintingRequestPWGRasterInternal());
-
   EXPECT_TRUE(SuccessfulResponseToURL(
       GURL("http://10.0.0.8:6006/privet/capabilities"),
       kSampleCapabilitiesResponsePWGOnly));
 
-  local_print_operation_->SendDataFile(base::FilePath("sample/file/path"));
-
   EXPECT_CALL(local_print_delegate_, OnPrivetPrintingDoneInternal());
 
   // TODO(noamsml): Is encoding spaces as pluses standard?
   EXPECT_TRUE(SuccessfulResponseToURLAndFilePath(
       GURL("http://10.0.0.8:6006/privet/printer/submitdoc?"
            "user=sample%40gmail.com&jobname=Sample+job+name"),
-      base::FilePath("sample/file/path"),
+      base::FilePath("path/to/test.pdf"),
       kSampleLocalPrintResponse));
 };
 
 TEST_F(PrivetLocalPrintTest, SuccessfulLocalPrintWithCreatejob) {
   local_print_operation_->SetUsername("sample@gmail.com");
   local_print_operation_->SetJobname("Sample job name");
   local_print_operation_->SetTicket("Sample print ticket");
+  local_print_operation_->SetData(RefCountedBytesFromString(

[Vitaly Buka (NO REVIEWS), 2013/11/15 06:48:38]

same

[Noam Samuel, 2013/11/15 19:13:46]

Done.

+      "Sample print data"));
   local_print_operation_->Start();
 
   EXPECT_TRUE(SuccessfulResponseToURL(
       GURL("http://10.0.0.8:6006/privet/info"),
       kSampleInfoResponseWithCreatejob));
 
-  EXPECT_CALL(local_print_delegate_, OnPrivetPrintingRequestPDFInternal());
-
   EXPECT_TRUE(SuccessfulResponseToURL(
       GURL("http://10.0.0.8:6006/privet/capabilities"),
       kSampleCapabilitiesResponse));
 
-  local_print_operation_->SendData("Sample print data");
-
   EXPECT_TRUE(SuccessfulResponseToURLAndData(
       GURL("http://10.0.0.8:6006/privet/printer/createjob"),
       "Sample print ticket",
       kSampleCreatejobResponse));
 
   EXPECT_CALL(local_print_delegate_, OnPrivetPrintingDoneInternal());
 
   // TODO(noamsml): Is encoding spaces as pluses standard?
   EXPECT_TRUE(SuccessfulResponseToURLAndData(
       GURL("http://10.0.0.8:6006/privet/printer/submitdoc?"
            "user=sample%40gmail.com&jobname=Sample+job+name&job_id=1234"),
       "Sample print data",
       kSampleLocalPrintResponse));
 };
 
 TEST_F(PrivetLocalPrintTest, PDFPrintInvalidDocumentTypeRetry) {
   local_print_operation_->SetUsername("sample@gmail.com");
   local_print_operation_->SetJobname("Sample job name");
   local_print_operation_->SetTicket("Sample print ticket");
+  local_print_operation_->SetData(RefCountedBytesFromString(
+      "sample/path/"));
   local_print_operation_->Start();
 
   EXPECT_TRUE(SuccessfulResponseToURL(
       GURL("http://10.0.0.8:6006/privet/info"),
       kSampleInfoResponseWithCreatejob));
 
-  EXPECT_CALL(local_print_delegate_, OnPrivetPrintingRequestPDFInternal());
-
   EXPECT_TRUE(SuccessfulResponseToURL(
       GURL("http://10.0.0.8:6006/privet/capabilities"),
       kSampleCapabilitiesResponse));
 
-  local_print_operation_->SendData("Sample print data");
-
   EXPECT_TRUE(SuccessfulResponseToURLAndData(
       GURL("http://10.0.0.8:6006/privet/printer/createjob"),
       "Sample print ticket",
       kSampleCreatejobResponse));
 
-  EXPECT_CALL(local_print_delegate_,
-              OnPrivetPrintingRequestPWGRasterInternal());
-
   // TODO(noamsml): Is encoding spaces as pluses standard?
   EXPECT_TRUE(SuccessfulResponseToURLAndData(
       GURL("http://10.0.0.8:6006/privet/printer/submitdoc?"
            "user=sample%40gmail.com&jobname=Sample+job+name&job_id=1234"),
-      "Sample print data",
+      "sample/path/",
       kSampleInvalidDocumentTypeResponse));
 
-  local_print_operation_->SendData("Sample print data2");
-
   EXPECT_CALL(local_print_delegate_, OnPrivetPrintingDoneInternal());
 
-  EXPECT_TRUE(SuccessfulResponseToURLAndData(
+  EXPECT_TRUE(SuccessfulResponseToURLAndFilePath(
       GURL("http://10.0.0.8:6006/privet/printer/submitdoc?"
            "user=sample%40gmail.com&jobname=Sample+job+name&job_id=1234"),
-      "Sample print data2",
+      base::FilePath("sample/path/test.pdf"),
       kSampleLocalPrintResponse));
 };
 
 TEST_F(PrivetLocalPrintTest, LocalPrintRetryOnInvalidJobID) {
   local_print_operation_->SetUsername("sample@gmail.com");
   local_print_operation_->SetJobname("Sample job name");
   local_print_operation_->SetTicket("Sample print ticket");
+  local_print_operation_->SetData(RefCountedBytesFromString(
+      "Sample print data"));
   local_print_operation_->Start();
 
   EXPECT_TRUE(SuccessfulResponseToURL(
       GURL("http://10.0.0.8:6006/privet/info"),
       kSampleInfoResponseWithCreatejob));
 
-  EXPECT_CALL(local_print_delegate_, OnPrivetPrintingRequestPDFInternal());
-
   EXPECT_TRUE(SuccessfulResponseToURL(
       GURL("http://10.0.0.8:6006/privet/capabilities"),
       kSampleCapabilitiesResponse));
 
-  local_print_operation_->SendData("Sample print data");
-
   EXPECT_TRUE(SuccessfulResponseToURLAndData(
       GURL("http://10.0.0.8:6006/privet/printer/createjob"),
       "Sample print ticket",
       kSampleCreatejobResponse));
 
   EXPECT_TRUE(SuccessfulResponseToURLAndData(
       GURL("http://10.0.0.8:6006/privet/printer/submitdoc?"
            "user=sample%40gmail.com&jobname=Sample+job+name&job_id=1234"),
       "Sample print data",
       kSampleErrorResponsePrinterBusy));
 
   RunFor(base::TimeDelta::FromSeconds(3));
 
   EXPECT_TRUE(SuccessfulResponseToURL(
       GURL("http://10.0.0.8:6006/privet/printer/createjob"),
       kSampleCreatejobResponse));
 };
 
 
 }  // namespace
 
 }  // namespace local_discovery