Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 735013002: Revert of Add a media scanner convenience class. (Closed)

Created:
6 years, 1 month ago by Michael Achenbach
Modified:
6 years, 1 month ago
Reviewers:
fukino, Ben Kwa
CC:
chromium-reviews, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, vitalyp+closure_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, dbeam+watch-closure_chromium.org, mtomasz
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Add a media scanner convenience class. (patchset #1 id:1 of https://codereview.chromium.org/730353002/) Reason for revert: [Sheriff] Fails on cros and ozone: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/34127 http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Tests%20%282%29/builds/3852 Original issue's description: > Add a media scanner convenience class. > > Create a new class that takes in a list of directories, recursively scans them for image and video files, and returns the resulting list. > > BUG=420680 > TEST=browser_test: FileManagerJsTest.MediaScannerTest > > Committed: https://crrev.com/340e607f73159216a2e7359c0a71170b9d4668f9 > Cr-Commit-Position: refs/heads/master@{#304582} TBR=fukino@chromium.org,kenobi@chromium.org NOTREECHECKS=true NOTRY=true BUG=420680 Committed: https://crrev.com/182392c4a2fdb0a82f967c271b781d027440fdd1 Cr-Commit-Position: refs/heads/master@{#304589}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -386 lines) Patch
M chrome/browser/chromeos/file_manager/file_manager_jstest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/test/data/file_manager/unit_tests/media_scanner_unittest.html View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/test/data/file_manager/unit_tests/media_scanner_unittest.js View 1 chunk +0 lines, -285 lines 0 comments Download
M ui/file_manager/file_manager/background/js/compiled_resources.gyp View 2 chunks +1 line, -3 lines 0 comments Download
D ui/file_manager/file_manager/background/js/media_scanner.js View 1 chunk +0 lines, -65 lines 0 comments Download
M ui/file_manager/file_manager/manifest.json View 1 chunk +0 lines, -1 line 0 comments Download
M ui/file_manager/file_manager_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Add a media scanner convenience class.
6 years, 1 month ago (2014-11-18 12:26:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/735013002/1
6 years, 1 month ago (2014-11-18 12:26:51 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-18 12:27:18 UTC) #3
commit-bot: I haz the power
6 years, 1 month ago (2014-11-18 12:28:14 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/182392c4a2fdb0a82f967c271b781d027440fdd1
Cr-Commit-Position: refs/heads/master@{#304589}

Powered by Google App Engine
This is Rietveld 408576698