Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 735003003: Remove all tests in fast/multicol/newmulticol/compare-with-old-impl. (Closed)

Created:
6 years, 1 month ago by andersr
Modified:
6 years, 1 month ago
CC:
blink-reviews, rune
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove all tests in fast/multicol/newmulticol/compare-with-old-impl. These tests are no longer needed, as almost all of them are already run in both implementations after the virtual/regionbasedmulticol suite was created. Only two tests are not run in both implementations (skipped for the old implementation). * fast/multicol/newmulticol/multicol-becomes-regular-block.html * fast/multicol/newmulticol/regular-block-becomes-multicol.html This patch simply enables those tests for the old implementation, to continue to ensure equality between implementations via the shared baseline. Three compare-with-old-impl tests are skipped on Mac, which is very strange, as the corresponding originals are reftests, and *not* skipped. Possibly, the skipping is outdated, although I didn't verify that. BUG=386567 R=mstensho@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185583

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1571 lines) Patch
M LayoutTests/TestExpectations View 2 chunks +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/anonymous-block-split-crash.html View 1 chunk +0 lines, -45 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/anonymous-block-split-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/body-make-paginated.html View 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/body-make-paginated-expected.html View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/body-make-unpaginated.html View 1 chunk +0 lines, -22 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/body-make-unpaginated-expected.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/div-make-paginated.html View 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/div-make-paginated-expected.html View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/div-make-unpaginated.html View 1 chunk +0 lines, -22 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/div-make-unpaginated-expected.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/div-x-horizontal-tb-ltr.html View 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/div-x-horizontal-tb-ltr-expected.html View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/div-x-horizontal-tb-rtl.html View 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/div-x-horizontal-tb-rtl-expected.html View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/div-x-vertical-lr-ltr.html View 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/div-x-vertical-lr-ltr-expected.html View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/div-x-vertical-lr-rtl.html View 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/div-x-vertical-lr-rtl-expected.html View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/div-x-vertical-rl-ltr.html View 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/div-x-vertical-rl-ltr-expected.html View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/div-x-vertical-rl-rtl.html View 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/div-x-vertical-rl-rtl-expected.html View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/html-make-paginated.html View 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/html-make-paginated-expected.html View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/html-make-unpaginated.html View 1 chunk +0 lines, -22 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/html-make-unpaginated-expected.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/multicol-becomes-paged-auto-height.html View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/multicol-becomes-paged-auto-height-expected.html View 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/multicol-becomes-paged-fixed-height.html View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/multicol-becomes-paged-fixed-height-expected.html View 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/multicol-becomes-regular-block.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/multicol-becomes-regular-block-expected.html View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/multicol-with-child-renderLayer-for-input.html View 1 chunk +0 lines, -22 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/multicol-with-child-renderLayer-for-input-expected.html View 1 chunk +0 lines, -22 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/overflow-content.html View 1 chunk +0 lines, -77 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/overflow-content-expected.html View 1 chunk +0 lines, -73 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/paged-becomes-multicol-auto-height.html View 1 chunk +0 lines, -27 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/paged-becomes-multicol-auto-height-expected.html View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/paged-becomes-multicol-fixed-height.html View 1 chunk +0 lines, -27 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/paged-becomes-multicol-fixed-height-expected.html View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/paged-x-to-paged-y.html View 1 chunk +0 lines, -22 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/paged-x-to-paged-y-expected.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/paged-y-to-paged-x.html View 1 chunk +0 lines, -22 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/paged-y-to-paged-x-expected.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/regular-block-becomes-multicol.html View 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/regular-block-becomes-multicol-expected.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/viewport-x-horizontal-bt-ltr.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/viewport-x-horizontal-bt-ltr-expected.html View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/viewport-x-horizontal-bt-rtl.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/viewport-x-horizontal-bt-rtl-expected.html View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/viewport-x-horizontal-tb-ltr.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/viewport-x-horizontal-tb-ltr-expected.html View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/viewport-x-horizontal-tb-rtl.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/viewport-x-horizontal-tb-rtl-expected.html View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/viewport-x-vertical-lr-ltr.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/viewport-x-vertical-lr-ltr-expected.html View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/viewport-x-vertical-lr-rtl.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/viewport-x-vertical-lr-rtl-expected.html View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/viewport-x-vertical-rl-ltr.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/viewport-x-vertical-rl-ltr-expected.html View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/viewport-x-vertical-rl-rtl.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/viewport-x-vertical-rl-rtl-expected.html View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/viewport-y-horizontal-bt-ltr.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/viewport-y-horizontal-bt-ltr-expected.html View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/viewport-y-horizontal-bt-rtl.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/viewport-y-horizontal-bt-rtl-expected.html View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/viewport-y-horizontal-tb-ltr.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/viewport-y-horizontal-tb-ltr-expected.html View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/viewport-y-horizontal-tb-rtl.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/viewport-y-horizontal-tb-rtl-expected.html View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/viewport-y-vertical-lr-ltr.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/viewport-y-vertical-lr-ltr-expected.html View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/viewport-y-vertical-lr-rtl.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/viewport-y-vertical-lr-rtl-expected.html View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/viewport-y-vertical-rl-ltr.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/viewport-y-vertical-rl-ltr-expected.html View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/viewport-y-vertical-rl-rtl.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/viewport-y-vertical-rl-rtl-expected.html View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
andersr
6 years, 1 month ago (2014-11-18 13:58:31 UTC) #1
mstensho (USE GERRIT)
lgtm. I find it hard to believe that the skipping of 3 tests on Mac ...
6 years, 1 month ago (2014-11-19 07:56:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/735003003/1
6 years, 1 month ago (2014-11-19 09:53:00 UTC) #4
andersr
On 2014/11/19 07:56:41, mstensho wrote: > lgtm. > > I find it hard to believe ...
6 years, 1 month ago (2014-11-19 09:58:07 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 10:37:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185583

Powered by Google App Engine
This is Rietveld 408576698