Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1725)

Unified Diff: Source/platform/transforms/PerspectiveTransformOperation.cpp

Issue 73493002: Fix blendToIdentity case in PerspectiveTransformOperation::blend Base URL: http://src.chromium.org/blink/trunk/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/animations/3d/transform-perspective.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/transforms/PerspectiveTransformOperation.cpp
===================================================================
--- Source/platform/transforms/PerspectiveTransformOperation.cpp (revision 160782)
+++ Source/platform/transforms/PerspectiveTransformOperation.cpp (working copy)
@@ -40,7 +40,7 @@
if (blendToIdentity) {
double p = floatValueForLength(m_p, 1);
- p = WebCore::blend(p, 1.0, progress); // FIXME: this seems wrong. https://bugs.webkit.org/show_bug.cgi?id=52700
+ p = 1.0 / WebCore::blend(1.0 / p, 0.0, progress);
Julien - ping for review 2013/12/05 01:18:45 This formula is overly complicated and it took me
return PerspectiveTransformOperation::create(Length(clampToPositiveInteger(p), Fixed));
}
« no previous file with comments | « LayoutTests/animations/3d/transform-perspective.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698