Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Side by Side Diff: Source/platform/transforms/PerspectiveTransformOperation.cpp

Issue 73493002: Fix blendToIdentity case in PerspectiveTransformOperation::blend Base URL: http://src.chromium.org/blink/trunk/
Patch Set: updated patch Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/animations/3d/transform-perspective-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2009 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY 13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #include "config.h" 26 #include "config.h"
27 #include "platform/transforms/PerspectiveTransformOperation.h" 27 #include "platform/transforms/PerspectiveTransformOperation.h"
28 28
29 #include "platform/animation/AnimationUtilities.h" 29 #include "platform/animation/AnimationUtilities.h"
30 #include "platform/transforms/IdentityTransformOperation.h"
30 #include "wtf/MathExtras.h" 31 #include "wtf/MathExtras.h"
31 32
32 using namespace std; 33 using namespace std;
33 34
34 namespace WebCore { 35 namespace WebCore {
35 36
36 PassRefPtr<TransformOperation> PerspectiveTransformOperation::blend(const Transf ormOperation* from, double progress, bool blendToIdentity) 37 PassRefPtr<TransformOperation> PerspectiveTransformOperation::blend(const Transf ormOperation* from, double progress, bool blendToIdentity)
37 { 38 {
38 if (from && !from->isSameType(*this)) 39 if (from && !from->isSameType(*this))
39 return this; 40 return this;
40 41
41 if (blendToIdentity) { 42 if (blendToIdentity) {
42 double p = WebCore::blend(m_p, 1., progress); // FIXME: this seems wrong . https://bugs.webkit.org/show_bug.cgi?id=52700 43 if (progress == 1) {
Julien - ping for review 2014/01/10 13:41:41 We don't put curly braces around single line if's.
44 return IdentityTransformOperation::create();
45 }
46 double p = m_p / (1 - progress);
43 return PerspectiveTransformOperation::create(clampToPositiveInteger(p)); 47 return PerspectiveTransformOperation::create(clampToPositiveInteger(p));
44 } 48 }
45 49
46 const PerspectiveTransformOperation* fromOp = static_cast<const PerspectiveT ransformOperation*>(from); 50 const PerspectiveTransformOperation* fromOp = static_cast<const PerspectiveT ransformOperation*>(from);
47 51
48 TransformationMatrix fromT; 52 TransformationMatrix fromT;
49 TransformationMatrix toT; 53 TransformationMatrix toT;
50 fromT.applyPerspective(fromOp ? fromOp->m_p : 0); 54 fromT.applyPerspective(fromOp ? fromOp->m_p : 0);
51 toT.applyPerspective(m_p); 55 toT.applyPerspective(m_p);
52 toT.blend(fromT, progress); 56 toT.blend(fromT, progress);
53 TransformationMatrix::DecomposedType decomp; 57 TransformationMatrix::DecomposedType decomp;
54 toT.decompose(decomp); 58 toT.decompose(decomp);
55 59
56 if (decomp.perspectiveZ) { 60 if (decomp.perspectiveZ) {
57 double val = -1.0 / decomp.perspectiveZ; 61 double val = -1.0 / decomp.perspectiveZ;
58 return PerspectiveTransformOperation::create(clampToPositiveInteger(val) ); 62 return PerspectiveTransformOperation::create(clampToPositiveInteger(val) );
59 } 63 }
60 return PerspectiveTransformOperation::create(0); 64 return PerspectiveTransformOperation::create(0);
61 } 65 }
62 66
63 } // namespace WebCore 67 } // namespace WebCore
OLDNEW
« no previous file with comments | « LayoutTests/animations/3d/transform-perspective-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698