Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 734873002: Use 16 instead of 4 for determining member offsets. (Closed)

Created:
6 years, 1 month ago by rickyz (no longer on Chrome)
Modified:
6 years, 1 month ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Use 16 instead of 4 for determining member offsets. This avoids UBSan warnings about unaligned memory access. BUG= Committed: https://chromium.googlesource.com/v8/v8/+/8b90dde20bd4e2e3ea53710130c5d2d7bd935c94

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/base/macros.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/heap/heap-inl.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
rickyz (no longer on Chrome)
Hey, I've been looking at ubsan warnings in chrome, and taking a stab at fixing ...
6 years, 1 month ago (2014-11-18 02:36:35 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 1 month ago (2014-11-18 13:41:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/734873002/1
6 years, 1 month ago (2014-11-18 13:41:49 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-18 14:09:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698