Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1020)

Issue 734853004: Fixes d8 on windows following. (Closed)

Created:
6 years, 1 month ago by bulach
Modified:
6 years, 1 month ago
CC:
ulan, v8-dev
Project:
v8
Visibility:
Public.

Description

Fixes d8 on windows following. Broke by https://codereview.chromium.org/740493002/ BUG= NOTRY=true NOTREECHECKS=true Committed: https://chromium.googlesource.com/v8/v8/+/a1861fd5a51275700b21d59c8197c531a87b857d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/d8.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
bulach
sigh, sorry! :( try bots didn't catch this..
6 years, 1 month ago (2014-11-18 20:46:38 UTC) #2
Dmitry Lomov (no reviews)
lgtm, please land this build fix.
6 years, 1 month ago (2014-11-18 21:05:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/734853004/1
6 years, 1 month ago (2014-11-18 21:11:12 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-18 21:11:27 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698