Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Issue 734853003: Misc clean-up of TabCaptureApiTests; and re-enable more tests. (Closed)

Created:
6 years, 1 month ago by miu
Modified:
6 years, 1 month ago
Reviewers:
hubbe
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Misc clean-up of TabCaptureApiTests; and re-enable more tests. 1. Consolidated ApiTestsAudio (and api_tests_audio.*) into ApiTests (and api_tests.*). 2. Removed checks for WinXP, since the real problem is likely this: http://crbug.com/177163 3. Removed duplication. 4. Minor comment clean-ups/additions. BUG=294431, 326319 Committed: https://crrev.com/57c8428afeee790503c9a3396dcf5ff0847608e2 Cr-Commit-Position: refs/heads/master@{#304941}

Patch Set 1 : #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -94 lines) Patch
M chrome/browser/extensions/api/tab_capture/tab_capture_apitest.cc View 9 chunks +17 lines, -41 lines 3 comments Download
M chrome/test/data/extensions/api_test/tab_capture/api_tests.js View 3 chunks +9 lines, -2 lines 0 comments Download
D chrome/test/data/extensions/api_test/tab_capture/api_tests_audio.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/extensions/api_test/tab_capture/api_tests_audio.js View 1 chunk +0 lines, -40 lines 2 comments Download
M chrome/test/data/extensions/api_test/tab_capture/constraints.js View 2 chunks +27 lines, -1 line 1 comment Download
D chrome/test/data/extensions/api_test/tab_capture/incognito.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/extensions/api_test/tab_capture/incognito.js View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
miu
hubbe: PTAL. Explanations of clean-ups in comments below: https://codereview.chromium.org/734853003/diff/20001/chrome/browser/extensions/api/tab_capture/tab_capture_apitest.cc File chrome/browser/extensions/api/tab_capture/tab_capture_apitest.cc (left): https://codereview.chromium.org/734853003/diff/20001/chrome/browser/extensions/api/tab_capture/tab_capture_apitest.cc#oldcode83 chrome/browser/extensions/api/tab_capture/tab_capture_apitest.cc:83: // ...
6 years, 1 month ago (2014-11-19 01:15:55 UTC) #3
hubbe
lgtm
6 years, 1 month ago (2014-11-19 23:20:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/734853003/20001
6 years, 1 month ago (2014-11-19 23:26:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
6 years, 1 month ago (2014-11-20 00:25:33 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 00:26:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/57c8428afeee790503c9a3396dcf5ff0847608e2
Cr-Commit-Position: refs/heads/master@{#304941}

Powered by Google App Engine
This is Rietveld 408576698