Issue 734843002: Safebrowsing: Fix crash if DownloadItem is destroyed before history check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 734843002: Safebrowsing: Fix crash if DownloadItem is destroyed before history check. (Closed)

Created:
6 years, 1 month ago by mattm

Modified:
6 years, 1 month ago

Reviewers:
noé

CC:
chromium-reviews, grt+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Safebrowsing: Fix crash if DownloadItem is destroyed before history check. BUG=433380 Committed: https://crrev.com/dece1d546a4c322fd0ea3a1044169de35b24f8cc Cr-Commit-Position: refs/heads/master@{#304953}

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -1 line)			Patch
	M	chrome/browser/safe_browsing/download_protection_service.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download
	M	chrome/browser/safe_browsing/download_protection_service_unittest.cc	View		4 chunks	+49 lines, -1 line	0 comments	Download

Total messages: 8 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/734843002/20001

6 years, 1 month ago (2014-11-20 00:39:03 UTC) #6

commit-bot: I haz the power

6 years, 1 month ago (2014-11-20 01:22:01 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/dece1d546a4c322fd0ea3a1044169de35b24f8cc
Cr-Commit-Position: refs/heads/master@{#304953}