Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 734843002: Safebrowsing: Fix crash if DownloadItem is destroyed before history check. (Closed)

Created:
6 years, 1 month ago by mattm
Modified:
6 years, 1 month ago
Reviewers:
noé
CC:
chromium-reviews, grt+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Safebrowsing: Fix crash if DownloadItem is destroyed before history check. BUG=433380 Committed: https://crrev.com/dece1d546a4c322fd0ea3a1044169de35b24f8cc Cr-Commit-Position: refs/heads/master@{#304953}

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -1 line) Patch
M chrome/browser/safe_browsing/download_protection_service.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/download_protection_service_unittest.cc View 4 chunks +49 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
mattm
6 years, 1 month ago (2014-11-19 21:41:15 UTC) #3
noé
lgtm
6 years, 1 month ago (2014-11-20 00:35:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/734843002/20001
6 years, 1 month ago (2014-11-20 00:39:03 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
6 years, 1 month ago (2014-11-20 01:20:57 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 01:22:01 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dece1d546a4c322fd0ea3a1044169de35b24f8cc
Cr-Commit-Position: refs/heads/master@{#304953}

Powered by Google App Engine
This is Rietveld 408576698