Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 734813004: Get rid of continuations. (Closed)

Created:
6 years, 1 month ago by ojan
Modified:
6 years, 1 month ago
Reviewers:
esprehn, eseidel
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Get rid of continuations. This is all dead code now that inlines can't contain blocks. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/48e8fddbc363361030b67ddd55dbaee31bb08fbe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -1071 lines) Patch
M sky/engine/core/rendering/InlineFlowBox.cpp View 4 chunks +8 lines, -39 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.h View 5 chunks +0 lines, -30 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.cpp View 15 chunks +14 lines, -466 lines 0 comments Download
M sky/engine/core/rendering/RenderBlockLineLayout.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.h View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/core/rendering/RenderBoxModelObject.h View 3 chunks +2 lines, -27 lines 0 comments Download
M sky/engine/core/rendering/RenderBoxModelObject.cpp View 7 chunks +3 lines, -52 lines 0 comments Download
M sky/engine/core/rendering/RenderInline.h View 3 chunks +0 lines, -19 lines 0 comments Download
M sky/engine/core/rendering/RenderInline.cpp View 14 chunks +5 lines, -400 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.h View 3 chunks +2 lines, -6 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.cpp View 3 chunks +0 lines, -12 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.h View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
ojan
6 years, 1 month ago (2014-11-18 04:19:12 UTC) #2
ojan
There's still considerably more cleanup to do around anonymous renderers, but that can be done ...
6 years, 1 month ago (2014-11-18 04:19:41 UTC) #3
esprehn
lgtm, rs=me (in 5 years someone is going to hate us...)
6 years, 1 month ago (2014-11-18 23:47:37 UTC) #4
ojan
6 years, 1 month ago (2014-11-19 00:56:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
48e8fddbc363361030b67ddd55dbaee31bb08fbe.

Powered by Google App Engine
This is Rietveld 408576698