Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 734733002: Revert of Move RegisterDomain/UnregisterDomain and its handling to inspector_websocket. (Closed)

Created:
6 years, 1 month ago by nednguyen
Modified:
6 years, 1 month ago
Reviewers:
dtu, chrishenry
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Move RegisterDomain/UnregisterDomain and its handling to inspector_websocket. (patchset #3 id:90001 of https://codereview.chromium.org/729833002/) Reason for revert: This may be the reason why stack trace is lost. Original issue's description: > Move RegisterDomain/UnregisterDomain and its handling to inspector_websocket. > Add unit tests. > > BUG=423954 > > Committed: https://crrev.com/79602d53643589ef1ce19cb115b1c91df4d5789f > Cr-Commit-Position: refs/heads/master@{#304448} TBR=dtu@chromium.org,chrishenry@google.com BUG=423954, 433966 Committed: https://crrev.com/8f622c4297d559d3ae17ed70d6ceabba97038920 Cr-Commit-Position: refs/heads/master@{#304497}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -235 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py View 4 chunks +47 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/inspector_websocket.py View 6 chunks +11 lines, -75 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/inspector_websocket_unittest.py View 2 chunks +53 lines, -155 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
nednguyen
Created Revert of Move RegisterDomain/UnregisterDomain and its handling to inspector_websocket.
6 years, 1 month ago (2014-11-17 21:14:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/734733002/1
6 years, 1 month ago (2014-11-17 21:18:27 UTC) #3
chrishenry
lgtm, thanks
6 years, 1 month ago (2014-11-17 21:52:16 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-17 22:22:34 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-17 22:23:15 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f622c4297d559d3ae17ed70d6ceabba97038920
Cr-Commit-Position: refs/heads/master@{#304497}

Powered by Google App Engine
This is Rietveld 408576698