Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 734633005: Revert of Revert of Add gpu support for Apple specific 'Vertex Arrays' functions (Closed)

Created:
6 years ago by Tom Hudson
Modified:
6 years ago
Reviewers:
bsalomon, paraboul
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Revert of Add gpu support for Apple specific 'Vertex Arrays' functions (patchset #1 id:1 of https://codereview.chromium.org/750973003/) Reason for revert: Original patchset seems to have been exonerated. Crash was mac-specific, but appears to be triggered by a non-mac-specific change (https://codereview.chromium.org/747043004/); suspecting driver bug? Original issue's description: > Revert of Add gpu support for Apple specific 'Vertex Arrays' functions (patchset #2 id:20001 of https://codereview.chromium.org/754653002/) > > Reason for revert: > Suspected in DM crashes, e.g. > > 2033 tasks left 344M peak 843ms tabl-cuteoverload_skp > Signal 11: > _sigtramp (+0x1a) > create_surface(CanvasConfig const&, GrContext*) (+0x1b2) > test_WritePixels(skiatest::Reporter*, GrContextFactory*) (+0x8d4) > skiatest::WritePixelsClass::onRun(skiatest::Reporter*) (+0x21) > skiatest::Test::run() (+0x7c) > DM::GpuTestTask::draw(GrContextFactory*) (+0x8c) > DM::GpuTask::run(GrContextFactory*) (+0xa6) > DM::TaskRunner::wait() (+0x7f) > dm_main() (+0x33f) > main (+0x27) > > > On all MacMini platforms (the following URL with -Mac{10.6,10.7,10.8}- and -{Debug,Release}): > > http://build.chromium.org/p/client.skia/builders/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug > > > Original issue's description: > > Add gpu support for Apple specific 'Vertex Arrays' functions > > > > BUG=skia: > > > > Committed: https://skia.googlesource.com/skia/+/af000f469e1b0153ce445c96ca3d20e6d12224cc > > TBR=bsalomon@google.com,paraboul@gmail.com > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/55fe3d7748b873e362edc4e6a43bd77914ed25fb TBR=bsalomon@google.com,paraboul@gmail.com NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/612e92680b13fa184965fd8fc7d573fc5e394ef8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/GrGLAssembleInterface.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Hudson
Created Revert of Revert of Add gpu support for Apple specific 'Vertex Arrays' functions
6 years ago (2014-11-24 19:21:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/734633005/1
6 years ago (2014-11-24 19:22:33 UTC) #2
commit-bot: I haz the power
6 years ago (2014-11-24 19:22:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/612e92680b13fa184965fd8fc7d573fc5e394ef8

Powered by Google App Engine
This is Rietveld 408576698