Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 734593003: [turbofan] Factor out common code between ReduceSelect and ReduceBranch in ControlReducer. (Closed)

Created:
6 years, 1 month ago by titzer
Modified:
6 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

[turbofan] Factor out common code between ReduceSelect and ReduceBranch in ControlReducer. R=bmeurer@chromium.org BUG= Committed: https://chromium.googlesource.com/v8/v8/+/ca268fe2a265a351d7195eaf218b3b5217ecfdae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -40 lines) Patch
M src/compiler/control-reducer.cc View 4 chunks +25 lines, -40 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
titzer
6 years, 1 month ago (2014-11-17 11:33:38 UTC) #1
Benedikt Meurer
lgtm
6 years, 1 month ago (2014-11-17 11:34:09 UTC) #2
titzer
6 years, 1 month ago (2014-11-17 11:35:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ca268fe2a265a351d7195eaf218b3b5217ecfdae (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698