Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 734423002: Prefix CommandLine usage with base namespace (Part 6: chromecast/) (Closed)

Created:
6 years, 1 month ago by elecro
Modified:
6 years ago
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, brettw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Prefix CommandLine usage with base namespace (Part 6: chromecast/) Prefix all CommandLine usage in the chromecast/ directory with the base:: namespace. R=gunsch@chromium.org,phajdan.jr@chromium.org BUG=422426 Committed: https://crrev.com/4a0bf7318e6515b1eb9ab07d4227f0bb788fff43 Cr-Commit-Position: refs/heads/master@{#305663}

Patch Set 1 #

Total comments: 1

Patch Set 2 : style fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M chromecast/browser/cast_browser_main_parts.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromecast/browser/test/chromecast_browser_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/browser/url_request_context_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/renderer/cast_content_renderer_client.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (1 generated)
elecro
Please take a look.
6 years, 1 month ago (2014-11-18 14:30:13 UTC) #1
gunsch
lgtm % nit https://codereview.chromium.org/734423002/diff/1/chromecast/renderer/cast_content_renderer_client.cc File chromecast/renderer/cast_content_renderer_client.cc (right): https://codereview.chromium.org/734423002/diff/1/chromecast/renderer/cast_content_renderer_client.cc#newcode37 chromecast/renderer/cast_content_renderer_client.cc:37: base::CommandLine* commandLine = base::CommandLine::ForCurrentProcess(); naming style ...
6 years, 1 month ago (2014-11-18 15:36:35 UTC) #2
elecro
On 2014/11/18 15:36:35, gunsch wrote: > lgtm % nit > > https://codereview.chromium.org/734423002/diff/1/chromecast/renderer/cast_content_renderer_client.cc > File chromecast/renderer/cast_content_renderer_client.cc ...
6 years, 1 month ago (2014-11-18 15:45:29 UTC) #3
gunsch
lgtm
6 years, 1 month ago (2014-11-18 16:00:48 UTC) #4
elecro
ping phajdan.jr@ for browser/test/* review
6 years ago (2014-11-25 11:58:34 UTC) #5
Paweł Hajdan Jr.
browser/test LGTM
6 years ago (2014-11-25 12:56:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/734423002/20001
6 years ago (2014-11-25 17:42:39 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-11-25 18:23:48 UTC) #9
commit-bot: I haz the power
6 years ago (2014-11-25 18:25:11 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4a0bf7318e6515b1eb9ab07d4227f0bb788fff43
Cr-Commit-Position: refs/heads/master@{#305663}

Powered by Google App Engine
This is Rietveld 408576698