Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 734403002: Prototype for a client-side performance trybot script. (Closed)

Created:
6 years, 1 month ago by Michael Achenbach
Modified:
6 years, 1 month ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Prototype for a client-side performance trybot script. BUG=chromium:374740 LOG=n TEST=tools/try_perf.py sunspider octane R=phajdan.jr@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/8d042464d9ddfc61ee090cf3d1df709358555e86

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Total comments: 1

Patch Set 4 : imports #

Patch Set 5 : Review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -0 lines) Patch
A tools/find_depot_tools.py View 1 chunk +40 lines, -0 lines 0 comments Download
A tools/try_perf.py View 1 2 3 4 1 chunk +44 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Achenbach
PTAL. It basically still uses the testfilter property under the hood. If I want to ...
6 years, 1 month ago (2014-11-18 14:20:40 UTC) #3
Paweł Hajdan Jr.
https://codereview.chromium.org/734403002/diff/40001/tools/try_perf.py File tools/try_perf.py (right): https://codereview.chromium.org/734403002/diff/40001/tools/try_perf.py#newcode23 tools/try_perf.py:23: return Return non-zero exit code (applies to all lines ...
6 years, 1 month ago (2014-11-18 14:24:11 UTC) #4
Michael Achenbach
On 2014/11/18 14:20:40, Michael Achenbach wrote: > PTAL. It basically still uses the testfilter property ...
6 years, 1 month ago (2014-11-18 14:24:50 UTC) #5
Michael Achenbach
Done
6 years, 1 month ago (2014-11-18 14:36:00 UTC) #6
Paweł Hajdan Jr.
LGTM
6 years, 1 month ago (2014-11-18 14:38:48 UTC) #7
Michael Achenbach
6 years, 1 month ago (2014-11-18 14:40:05 UTC) #8
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
8d042464d9ddfc61ee090cf3d1df709358555e86 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698