Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: chrome/browser/task_manager.cc

Issue 7344: Convert GetPreferredSize from:... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/task_manager.cc
===================================================================
--- chrome/browser/task_manager.cc (revision 3391)
+++ chrome/browser/task_manager.cc (working copy)
@@ -666,7 +666,7 @@
void Init(TaskManagerTableModel* table_model);
virtual void Layout();
- virtual void GetPreferredSize(CSize* out);
+ virtual gfx::Size GetPreferredSize();
virtual void DidChangeBounds(const CRect& previous, const CRect& current);
virtual void ViewHierarchyChanged(bool is_add, ChromeViews::View* parent,
ChromeViews::View* child);
@@ -844,10 +844,9 @@
int x = bounds.left;
int y = bounds.top;
- CSize size;
- kill_button_->GetPreferredSize(&size);
- int prefered_width = size.cx;
- int prefered_height = size.cy;
+ gfx::Size size = kill_button_->GetPreferredSize();
+ int prefered_width = size.width();
+ int prefered_height = size.height();
tab_table_->SetBounds(
x + kPanelHorizMargin,
@@ -866,9 +865,9 @@
prefered_width,
prefered_height);
- about_memory_link_->GetPreferredSize(&size);
- int link_prefered_width = size.cx;
- int link_prefered_height = size.cy;
+ size = about_memory_link_->GetPreferredSize();
+ int link_prefered_width = size.width();
+ int link_prefered_height = size.height();
// center between the two buttons horizontally, and line up with
// bottom of buttons vertically.
int link_y_offset = std::max(0, prefered_height - link_prefered_height) / 2;
@@ -879,9 +878,8 @@
link_prefered_height);
}
-void TaskManagerContents::GetPreferredSize(CSize* out) {
- out->cx = kDefaultWidth;
- out->cy = kDefaultHeight;
+gfx::Size TaskManagerContents::GetPreferredSize() {
+ return gfx::Size(kDefaultWidth, kDefaultHeight);
}
void TaskManagerContents::GetSelection(std::vector<int>* selection) {

Powered by Google App Engine
This is Rietveld 408576698