Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1675)

Unified Diff: chrome/browser/views/first_run_customize_view.cc

Issue 7344: Convert GetPreferredSize from:... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/views/first_run_customize_view.cc
===================================================================
--- chrome/browser/views/first_run_customize_view.cc (revision 3391)
+++ chrome/browser/views/first_run_customize_view.cc (working copy)
@@ -83,11 +83,10 @@
quick_shortcut_cbox_->SetIsSelected(true);
}
-void FirstRunCustomizeView::GetPreferredSize(CSize *out) {
- DCHECK(out);
- *out = ChromeViews::Window::GetLocalizedContentsSize(
+gfx::Size FirstRunCustomizeView::GetPreferredSize() {
+ return gfx::Size(ChromeViews::Window::GetLocalizedContentsSize(
IDS_FIRSTRUNCUSTOMIZE_DIALOG_WIDTH_CHARS,
- IDS_FIRSTRUNCUSTOMIZE_DIALOG_HEIGHT_LINES).ToSIZE();
+ IDS_FIRSTRUNCUSTOMIZE_DIALOG_HEIGHT_LINES));
}
void FirstRunCustomizeView::Layout() {
@@ -96,63 +95,62 @@
const int kVertSpacing = 8;
const int kComboExtraPad = 8;
- CSize canvas;
- GetPreferredSize(&canvas);
+ gfx::Size canvas = GetPreferredSize();
// Welcome label goes in to to the left. It does not go across the
// entire window because the background gets busy on the right.
- CSize pref_size;
- main_label_->GetPreferredSize(&pref_size);
+ gfx::Size pref_size = main_label_->GetPreferredSize();
main_label_->SetBounds(kPanelHorizMargin, kPanelVertMargin,
- canvas.cx - pref_size.cx, pref_size.cy);
+ canvas.width() - pref_size.width(),
+ pref_size.height());
AdjustDialogWidth(main_label_);
int next_v_space = background_image()->y() +
background_image()->height() + kPanelVertMargin;
- import_cbox_->GetPreferredSize(&pref_size);
+ pref_size = import_cbox_->GetPreferredSize();
import_cbox_->SetBounds(kPanelHorizMargin, next_v_space,
- pref_size.cx, pref_size.cy);
+ pref_size.width(), pref_size.height());
import_cbox_->SetIsSelected(true);
int x_offset = import_cbox_->x() +
import_cbox_->width();
- import_from_combo_->GetPreferredSize(&pref_size);
+ pref_size = import_from_combo_->GetPreferredSize();
import_from_combo_->SetBounds(x_offset,
next_v_space +
(import_cbox_->height() -
- pref_size.cy) / 2,
- pref_size.cx + kComboExtraPad,
- pref_size.cy);
+ pref_size.height()) / 2,
+ pref_size.width() + kComboExtraPad,
+ pref_size.height());
AdjustDialogWidth(import_from_combo_);
next_v_space = import_cbox_->y() + import_cbox_->height() +
kUnrelatedControlVerticalSpacing;
- shortcuts_label_->GetPreferredSize(&pref_size);
+ pref_size = shortcuts_label_->GetPreferredSize();
shortcuts_label_->SetBounds(kPanelHorizMargin, next_v_space,
- pref_size.cx, pref_size.cy);
+ pref_size.width(), pref_size.height());
AdjustDialogWidth(shortcuts_label_);
next_v_space += shortcuts_label_->height() +
kRelatedControlVerticalSpacing;
- desktop_shortcut_cbox_->GetPreferredSize(&pref_size);
+ pref_size = desktop_shortcut_cbox_->GetPreferredSize();
desktop_shortcut_cbox_->SetBounds(kPanelHorizMargin, next_v_space,
- pref_size.cx, pref_size.cy);
+ pref_size.width(), pref_size.height());
AdjustDialogWidth(desktop_shortcut_cbox_);
next_v_space += desktop_shortcut_cbox_->height() +
kRelatedControlVerticalSpacing;
- quick_shortcut_cbox_->GetPreferredSize(&pref_size);
+ pref_size = quick_shortcut_cbox_->GetPreferredSize();
quick_shortcut_cbox_->SetBounds(kPanelHorizMargin, next_v_space,
- pref_size.cx, pref_size.cy);
+ pref_size.width(), pref_size.height());
AdjustDialogWidth(quick_shortcut_cbox_);
}

Powered by Google App Engine
This is Rietveld 408576698