Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6036)

Unified Diff: chrome/browser/views/tabs/tab_strip.cc

Issue 7344: Convert GetPreferredSize from:... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/views/tabs/tab_strip.cc
===================================================================
--- chrome/browser/views/tabs/tab_strip.cc (revision 3391)
+++ chrome/browser/views/tabs/tab_strip.cc (working copy)
@@ -197,7 +197,7 @@
if (start_tab_count < end_tab_count &&
start_unselected_width_ < standard_tab_width) {
double minimum_tab_width =
- static_cast<double>(TabRenderer::GetMinimumSize().width());
+ static_cast<double>(TabRenderer::GetMinimumUnselectedSize().width());
start_unselected_width_ -= minimum_tab_width / start_tab_count;
}
tabstrip_->GenerateIdealBounds();
@@ -247,7 +247,7 @@
double target_width =
is_selected ? end_unselected_width_ : end_selected_width_;
double start_width = is_selected ? Tab::GetMinimumSelectedSize().width() :
- Tab::GetMinimumSize().width();
+ Tab::GetMinimumUnselectedSize().width();
double delta = target_width - start_width;
if (delta > 0)
return start_width + (delta * animation_.GetCurrentValue());
@@ -294,7 +294,8 @@
// of the animation.
// Removed animated Tabs are never selected.
double start_width = start_unselected_width_;
- double target_width = Tab::GetMinimumSize().width() + kTabHOffset;
+ double target_width =
+ Tab::GetMinimumUnselectedSize().width() + kTabHOffset;
double delta = start_width - target_width;
return start_width - (delta * animation_.GetCurrentValue());
}
@@ -508,9 +509,7 @@
}
int TabStrip::GetPreferredHeight() {
- CSize preferred_size;
- GetPreferredSize(&preferred_size);
- return preferred_size.cy;
+ return GetPreferredSize().height();
}
bool TabStrip::HasAvailableDragActions() const {
@@ -676,10 +675,8 @@
SchedulePaint();
}
-void TabStrip::GetPreferredSize(CSize* preferred_size) {
- DCHECK(preferred_size);
- preferred_size->cx = 0;
- preferred_size->cy = Tab::GetMinimumSize().height();
+gfx::Size TabStrip::GetPreferredSize() {
+ return gfx::Size(0, Tab::GetMinimumUnselectedSize().height());
}
void TabStrip::OnDragEntered(const DropTargetEvent& event) {
@@ -1157,7 +1154,7 @@
void TabStrip::GetDesiredTabWidths(int tab_count,
double* unselected_width,
double* selected_width) const {
- const double min_unselected_width = Tab::GetMinimumSize().width();
+ const double min_unselected_width = Tab::GetMinimumUnselectedSize().width();
const double min_selected_width = Tab::GetMinimumSelectedSize().width();
if (tab_count == 0) {
// Return immediately to avoid divide-by-zero below.

Powered by Google App Engine
This is Rietveld 408576698