Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Side by Side Diff: chrome/browser/views/options/languages_page_view.cc

Issue 7344: Convert GetPreferredSize from:... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 #include <windows.h> 4 #include <windows.h>
5 #include <shlobj.h> 5 #include <shlobj.h>
6 #include <vsstyle.h> 6 #include <vsstyle.h>
7 #include <vssym32.h> 7 #include <vssym32.h>
8 8
9 #include "chrome/browser/views/options/languages_page_view.h" 9 #include "chrome/browser/views/options/languages_page_view.h"
10 10
(...skipping 211 matching lines...) Expand 10 before | Expand all | Expand 10 after
222 virtual bool IsModal() const { return true; } 222 virtual bool IsModal() const { return true; }
223 virtual ChromeViews::View* GetContentsView() { return this; } 223 virtual ChromeViews::View* GetContentsView() { return this; }
224 224
225 // ChromeViews::ComboBox::Listener implementation: 225 // ChromeViews::ComboBox::Listener implementation:
226 virtual void ItemChanged(ChromeViews::ComboBox* combo_box, 226 virtual void ItemChanged(ChromeViews::ComboBox* combo_box,
227 int prev_index, 227 int prev_index,
228 int new_index); 228 int new_index);
229 229
230 // ChromeViews::View overrides. 230 // ChromeViews::View overrides.
231 virtual void Layout(); 231 virtual void Layout();
232 virtual void GetPreferredSize(CSize *out); 232 virtual gfx::Size GetPreferredSize();
233 233
234 protected: 234 protected:
235 virtual void ViewHierarchyChanged(bool is_add, ChromeViews::View* parent, 235 virtual void ViewHierarchyChanged(bool is_add, ChromeViews::View* parent,
236 ChromeViews::View* child); 236 ChromeViews::View* child);
237 237
238 private: 238 private:
239 void Init(); 239 void Init();
240 240
241 // The Options dialog window. 241 // The Options dialog window.
242 ChromeViews::Window* container_; 242 ChromeViews::Window* container_;
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
283 } 283 }
284 284
285 void AddLanguageWindowView::ItemChanged(ChromeViews::ComboBox* combo_box, 285 void AddLanguageWindowView::ItemChanged(ChromeViews::ComboBox* combo_box,
286 int prev_index, 286 int prev_index,
287 int new_index) { 287 int new_index) {
288 accept_language_selected_ = accept_language_combobox_model_-> 288 accept_language_selected_ = accept_language_combobox_model_->
289 GetLocaleFromIndex(new_index); 289 GetLocaleFromIndex(new_index);
290 } 290 }
291 291
292 void AddLanguageWindowView::Layout() { 292 void AddLanguageWindowView::Layout() {
293 CSize sz; 293 gfx::Size sz = accept_language_combobox_->GetPreferredSize();
294 accept_language_combobox_->GetPreferredSize(&sz);
295 accept_language_combobox_->SetBounds(kDialogPadding, kDialogPadding, 294 accept_language_combobox_->SetBounds(kDialogPadding, kDialogPadding,
296 width() - 2*kDialogPadding, sz.cy); 295 width() - 2*kDialogPadding,
296 sz.height());
297 } 297 }
298 298
299 void AddLanguageWindowView::GetPreferredSize(CSize* out) { 299 gfx::Size AddLanguageWindowView::GetPreferredSize() {
300 DCHECK(out);
301 ResourceBundle& rb = ResourceBundle::GetSharedInstance(); 300 ResourceBundle& rb = ResourceBundle::GetSharedInstance();
302 ChromeFont font = rb.GetFont(ResourceBundle::BaseFont); 301 ChromeFont font = rb.GetFont(ResourceBundle::BaseFont);
303 out->cx = font.ave_char_width() * kDefaultWindowWidthChars; 302 return gfx::Size(font.ave_char_width() * kDefaultWindowWidthChars,
304 out->cy = font.height() * kDefaultWindowHeightLines; 303 font.height() * kDefaultWindowHeightLines);
305 } 304 }
306 305
307 void AddLanguageWindowView::ViewHierarchyChanged( 306 void AddLanguageWindowView::ViewHierarchyChanged(
308 bool is_add, ChromeViews::View* parent, ChromeViews::View* child) { 307 bool is_add, ChromeViews::View* parent, ChromeViews::View* child) {
309 // Can't init before we're inserted into a ViewContainer, because we require 308 // Can't init before we're inserted into a ViewContainer, because we require
310 // a HWND to parent native child controls to. 309 // a HWND to parent native child controls to.
311 if (is_add && child == this) 310 if (is_add && child == this)
312 Init(); 311 Init();
313 } 312 }
314 313
(...skipping 431 matching lines...) Expand 10 before | Expand all | Expand 10 after
746 language_order_table_->Select(item_selected - 1); 745 language_order_table_->Select(item_selected - 1);
747 746
748 OnSelectionChanged(); 747 OnSelectionChanged();
749 } 748 }
750 749
751 void LanguagesPageView::SaveChanges() { 750 void LanguagesPageView::SaveChanges() {
752 if (language_order_table_model_.get() && language_table_edited_) 751 if (language_order_table_model_.get() && language_table_edited_)
753 accept_languages_.SetValue(language_order_table_model_->GetLanguageList()); 752 accept_languages_.SetValue(language_order_table_model_->GetLanguageList());
754 } 753 }
755 754
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698