Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: mojo/services/gles2/command_buffer_impl.h

Issue 734273002: Cleanse mojo/services/gles2 of InterfaceImpl (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/gles2/command_buffer_impl.h
diff --git a/mojo/services/gles2/command_buffer_impl.h b/mojo/services/gles2/command_buffer_impl.h
index c67effa15f27e5ce92a1329c33d300160740ca20..6c58ff74f9f4c2bc131f8e7cd1bf1ec8a504d2f7 100644
--- a/mojo/services/gles2/command_buffer_impl.h
+++ b/mojo/services/gles2/command_buffer_impl.h
@@ -8,6 +8,7 @@
#include "base/macros.h"
#include "base/memory/scoped_ptr.h"
#include "base/timer/timer.h"
+#include "mojo/public/cpp/bindings/strong_binding.h"
#include "mojo/public/cpp/system/core.h"
#include "mojo/services/public/interfaces/gpu/command_buffer.mojom.h"
#include "ui/gfx/native_widget_types.h"
@@ -31,13 +32,15 @@ class GLSurface;
namespace mojo {
-class CommandBufferImpl : public InterfaceImpl<CommandBuffer> {
+class CommandBufferImpl : public CommandBuffer {
public:
// Offscreen.
- CommandBufferImpl(gfx::GLShareGroup* share_group,
+ CommandBufferImpl(ScopedMessagePipeHandle handle,
jamesr 2014/11/18 05:24:20 can these take InterfaceRequest<>s? you can bind t
+ gfx::GLShareGroup* share_group,
gpu::gles2::MailboxManager* mailbox_manager);
// Onscreen.
- CommandBufferImpl(gfx::AcceleratedWidget widget,
+ CommandBufferImpl(ScopedMessagePipeHandle handle,
+ gfx::AcceleratedWidget widget,
const gfx::Size& size,
gfx::GLShareGroup* share_group,
gpu::gles2::MailboxManager* mailbox_manager);
@@ -73,6 +76,8 @@ class CommandBufferImpl : public InterfaceImpl<CommandBuffer> {
scoped_refptr<gfx::GLShareGroup> share_group_;
scoped_refptr<gpu::gles2::MailboxManager> mailbox_manager_;
+ StrongBinding<CommandBuffer> binding_;
+
DISALLOW_COPY_AND_ASSIGN(CommandBufferImpl);
};
« no previous file with comments | « no previous file | mojo/services/gles2/command_buffer_impl.cc » ('j') | mojo/services/gles2/command_buffer_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698