Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 734273002: Cleanse mojo/services/gles2 of InterfaceImpl (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Cleanse mojo/services/gles2 of InterfaceImpl Now we use StrongBinding, which is the new hotness. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9f3a2dd27b833570c554cb0e586267e6bda78ccb

Patch Set 1 #

Total comments: 2

Patch Set 2 : Moar interface request #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -29 lines) Patch
M mojo/services/gles2/command_buffer_impl.h View 1 3 chunks +8 lines, -3 lines 0 comments Download
M mojo/services/gles2/command_buffer_impl.cc View 1 4 chunks +12 lines, -8 lines 0 comments Download
M mojo/services/gles2/gpu_impl.h View 1 3 chunks +6 lines, -3 lines 0 comments Download
M mojo/services/gles2/gpu_impl.cc View 1 2 chunks +10 lines, -11 lines 0 comments Download
M mojo/services/native_viewport/main.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M mojo/shell/context.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
abarth-chromium
6 years, 1 month ago (2014-11-18 04:21:05 UTC) #1
jamesr
lgtm if you stick to InterfaceRequest<>. It's move-only so you have to .Pass() it a ...
6 years, 1 month ago (2014-11-18 05:24:20 UTC) #2
abarth-chromium
Oh, neat. Will do.
6 years, 1 month ago (2014-11-18 05:26:56 UTC) #3
abarth-chromium
6 years, 1 month ago (2014-11-18 06:24:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
9f3a2dd27b833570c554cb0e586267e6bda78ccb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698