components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc - Issue 734263003: Move data reduction proxy logic out of chrome and android webview network delegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc

Issue 734263003: Move data reduction proxy logic out of chrome and android webview network delegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Test fix Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc

index b0b574df9c8c109f9c82a092d8a49545fbe3befc..64b0ed12d67ddc786613a378f069fa1496a7962f 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc

@@ -97,7 +97,9 @@ TEST_F(ChromeNetworkDataSavingMetricsTest, TotalLengths) {

UpdateContentLengthPrefs(

kReceivedLength, kOriginalLength,

- &pref_service_, UNKNOWN_TYPE, statistics_prefs_.get());

+ pref_service_.GetBoolean(

+ data_reduction_proxy::prefs::kDataReductionProxyEnabled),

+ UNKNOWN_TYPE, statistics_prefs_.get());

EXPECT_EQ(kReceivedLength,

statistics_prefs_->GetInt64(

@@ -111,7 +113,9 @@ TEST_F(ChromeNetworkDataSavingMetricsTest, TotalLengths) {

// Record the same numbers again, and total lengths should be doubled.