Issue 7342017: ntp4: Most Visited appearance refresh

Issue 7342017: ntp4: Most Visited appearance refresh (Closed)

Created:
9 years, 5 months ago by Evan Stade

Modified:
9 years, 5 months ago

Reviewers:
csilv, Rick Byers

CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

ntp4: Most Visited appearance refresh match new mocks: remove edit bar, don't allow drag-reorder, move close button into thumbnail, add hover/active effects to thumbnail BUG=none TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92242

Patch Set 1 #

Patch Set 2 : cursor #

Total comments: 3

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -199 lines)			Patch
M	chrome/browser/resources/ntp4/most_visited_page.css	View		5 chunks	+34 lines, -116 lines	0 comments	Download
M	chrome/browser/resources/ntp4/most_visited_page.js	View	1	7 chunks	+15 lines, -71 lines	3 comments	Download
M	chrome/browser/resources/ntp4/new_tab.css	View	1	1 chunk	+10 lines, -6 lines	0 comments	Download
M	chrome/browser/resources/ntp4/new_tab.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/ntp4/new_tab_theme.css	View	1	2 chunks	+1 line, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

csilv

lgtm http://codereview.chromium.org/7342017/diff/1006/chrome/browser/resources/ntp4/most_visited_page.js File chrome/browser/resources/ntp4/most_visited_page.js (right): http://codereview.chromium.org/7342017/diff/1006/chrome/browser/resources/ntp4/most_visited_page.js#newcode288 chrome/browser/resources/ntp4/most_visited_page.js:288: * page is pinned. Thus we try to ...

9 years, 5 months ago (2011-07-12 21:31:09 UTC) #2

Evan Stade

9 years, 5 months ago (2011-07-12 21:47:29 UTC) #3

http://codereview.chromium.org/7342017/diff/1006/chrome/browser/resources/ntp...
File chrome/browser/resources/ntp4/most_visited_page.js (right):

http://codereview.chromium.org/7342017/diff/1006/chrome/browser/resources/ntp...
chrome/browser/resources/ntp4/most_visited_page.js:297: // Copy over pinned
sites directly.
On 2011/07/12 21:31:09, csilv wrote:
> This block is obsolete.

it doesn't do any harm so I left it there for now. Removing it would require
fixing some tests, and for all I know someone may change their mind in the
future and want pinning back. So I will remove it when we rip out the rest of
the pinning infrastructure (C++ side).

Expand Messages | Collapse Messages