Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 734163007: Linux-specific bits for loading V8's initial snapshot from external files. (Closed)

Created:
6 years, 1 month ago by baixo
Modified:
6 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Linux-specific bits for loading V8's initial snapshot from external files. BUG=421063 Committed: https://crrev.com/928c671d111e7123b752e61ec163959442bf6564 Cr-Commit-Position: refs/heads/master@{#304601}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M chrome/tools/build/linux/FILES.cfg View 1 chunk +8 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +5 lines, -1 line 2 comments Download

Messages

Total messages: 9 (2 generated)
baixo1
jochen: could you please take a look? Thanks!
6 years, 1 month ago (2014-11-18 13:15:32 UTC) #2
jochen (gone - plz use gerrit)
https://codereview.chromium.org/734163007/diff/1/content/content_tests.gypi File content/content_tests.gypi (right): https://codereview.chromium.org/734163007/diff/1/content/content_tests.gypi#newcode343 content/content_tests.gypi:343: 'content.gyp:content_v8_external_data', shouldn't this move as well?
6 years, 1 month ago (2014-11-18 13:43:00 UTC) #3
baixo1
https://codereview.chromium.org/734163007/diff/1/content/content_tests.gypi File content/content_tests.gypi (right): https://codereview.chromium.org/734163007/diff/1/content/content_tests.gypi#newcode343 content/content_tests.gypi:343: 'content.gyp:content_v8_external_data', On 2014/11/18 13:42:59, jochen (slow) wrote: > shouldn't ...
6 years, 1 month ago (2014-11-18 13:49:46 UTC) #4
jochen (gone - plz use gerrit)
ah, ok lgtm then
6 years, 1 month ago (2014-11-18 13:50:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/734163007/1
6 years, 1 month ago (2014-11-18 13:54:10 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-18 14:39:37 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-18 14:40:28 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/928c671d111e7123b752e61ec163959442bf6564
Cr-Commit-Position: refs/heads/master@{#304601}

Powered by Google App Engine
This is Rietveld 408576698