Chromium Code Reviews
DescriptionRevert of Revert of Revert of Make ninja display elapsed compile time by default. (patchset #1 id:1 of https://codereview.chromium.org/483853002/)
Reason for revert:
see discussion in https://codereview.chromium.org/483853002/
Original issue's description:
> Revert of Revert of Make ninja display elapsed compile time by default. (patchset #1 of https://codereview.chromium.org/405733002/)
>
> Reason for revert:
> see discussion in https://codereview.chromium.org/268833006/
>
> Original issue's description:
> > Revert of Make ninja display elapsed compile time by default. (https://codereview.chromium.org/268833006/)
> >
> > Reason for revert:
> > This made the build pages more noisy and happened to not be as useful as hoped in practice.
> >
> > If someone wants to use this to debug something, please add it temporarily while you debug, and then remove it again when you're done.
> >
> > Original issue's description:
> > > Make ninja display elapsed compile time by default.
> > >
> > > This will help debug slow or hanging compiles.
> > >
> > > BUG=none
> > >
> > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=269042
> >
> > r287547
>
> TBR=thakis@chromium.org
>
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=290324
TBR=stip@chromium.org,phajdan.jr@chromium.org,thakis@chromium.org,jabdelmalek@google.com
NOTREECHECKS=true
NOTRY=true
Patch Set 1 #
Created: 6 years, 1 month ago
(Patch set is too large to download)
Messages
Total messages: 5 (1 generated)
|
|||||||||||||||||||