Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 734143002: Revert of Revert of Revert of Make ninja display elapsed compile time by default. (Closed)

Created:
6 years, 1 month ago by jam
Modified:
5 years, 7 months ago
CC:
chromium-reviews, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org
Visibility:
Public.

Description

Revert of Revert of Revert of Make ninja display elapsed compile time by default. (patchset #1 id:1 of https://codereview.chromium.org/483853002/) Reason for revert: see discussion in https://codereview.chromium.org/483853002/ Original issue's description: > Revert of Revert of Make ninja display elapsed compile time by default. (patchset #1 of https://codereview.chromium.org/405733002/) > > Reason for revert: > see discussion in https://codereview.chromium.org/268833006/ > > Original issue's description: > > Revert of Make ninja display elapsed compile time by default. (https://codereview.chromium.org/268833006/) > > > > Reason for revert: > > This made the build pages more noisy and happened to not be as useful as hoped in practice. > > > > If someone wants to use this to debug something, please add it temporarily while you debug, and then remove it again when you're done. > > > > Original issue's description: > > > Make ninja display elapsed compile time by default. > > > > > > This will help debug slow or hanging compiles. > > > > > > BUG=none > > > > > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=269042 > > > > r287547 > > TBR=thakis@chromium.org > > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=290324 TBR=stip@chromium.org,phajdan.jr@chromium.org,thakis@chromium.org,jabdelmalek@google.com NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M scripts/slave/compile.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
jam
Created Revert of Revert of Revert of Make ninja display elapsed compile time by default.
6 years, 1 month ago (2014-11-17 17:19:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/734143002/1
6 years, 1 month ago (2014-11-17 17:20:02 UTC) #2
commit-bot: I haz the power
Failed to apply patch for build/scripts/slave/compile.py: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 1 month ago (2014-11-17 17:20:06 UTC) #4
Nico
6 years, 1 month ago (2014-11-17 23:43:36 UTC) #5
I'm landing a rebased version of this at
https://codereview.chromium.org/730213003

Powered by Google App Engine
This is Rietveld 408576698