Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: content/browser/battery_status/battery_monitor_impl_browsertest.cc

Issue 734123002: Mojify the battery status browsertests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Back to using the content client API now that it's landed. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/battery_status/battery_monitor_integration_browsertest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h"
6 #include "base/synchronization/waitable_event.h"
7 #include "base/thread_task_runner_handle.h" 5 #include "base/thread_task_runner_handle.h"
8 #include "content/public/browser/web_contents.h" 6 #include "content/public/browser/web_contents.h"
9 #include "content/public/common/content_switches.h"
10 #include "content/public/test/content_browser_test.h" 7 #include "content/public/test/content_browser_test.h"
11 #include "content/public/test/content_browser_test_utils.h" 8 #include "content/public/test/content_browser_test_utils.h"
12 #include "content/public/test/test_navigation_observer.h" 9 #include "content/public/test/test_navigation_observer.h"
13 #include "content/public/test/test_utils.h" 10 #include "content/public/test/test_utils.h"
14 #include "content/shell/browser/shell.h" 11 #include "content/shell/browser/shell.h"
15 #include "device/battery/battery_status_manager.h" 12 #include "device/battery/battery_status_manager.h"
16 #include "device/battery/battery_status_service.h" 13 #include "device/battery/battery_status_service.h"
17 14
15 // These tests run against the default implementation of the BatteryMonitor
16 // service, with a dummy BatteryManager set as a source of the battery
17 // information. They can be run only on platforms that use the default service
18 // implementation, ie. on the platforms where BatteryStatusService is used.
19
18 namespace content { 20 namespace content {
19 21
20 namespace { 22 namespace {
21 23
22 class FakeBatteryManager : public device::BatteryStatusManager { 24 class FakeBatteryManager : public device::BatteryStatusManager {
23 public: 25 public:
24 explicit FakeBatteryManager( 26 explicit FakeBatteryManager(
25 const device::BatteryStatusService::BatteryUpdateCallback& callback) 27 const device::BatteryStatusService::BatteryUpdateCallback& callback)
26 : callback_(callback), battery_status_available_(true), started_(false) {} 28 : callback_(callback), battery_status_available_(true), started_(false) {}
27 ~FakeBatteryManager() override {} 29 ~FakeBatteryManager() override {}
28 30
29 // Methods from BatteryStatusManager. 31 // Methods from BatteryStatusManager.
30 bool StartListeningBatteryChange() override { 32 bool StartListeningBatteryChange() override {
31 started_ = true; 33 started_ = true;
32 if (battery_status_available_) 34 if (battery_status_available_)
33 InvokeUpdateCallback(); 35 InvokeUpdateCallback();
34 return battery_status_available_; 36 return battery_status_available_;
35 } 37 }
36 38
37 void StopListeningBatteryChange() override {} 39 void StopListeningBatteryChange() override {}
38 40
39 void InvokeUpdateCallback() { 41 void InvokeUpdateCallback() {
40 // Invoke asynchronously to mimic the OS-specific battery managers. 42 // Invoke asynchronously to mimic the OS-specific battery managers.
41 base::ThreadTaskRunnerHandle::Get()->PostTask( 43 base::ThreadTaskRunnerHandle::Get()->PostTask(
42 FROM_HERE, 44 FROM_HERE, base::Bind(callback_, status_));
43 base::Bind(callback_, status_));
44 } 45 }
45 46
46 void set_battery_status(const device::BatteryStatus& status) { 47 void set_battery_status(const device::BatteryStatus& status) {
47 status_ = status; 48 status_ = status;
48 } 49 }
49 50
50 void set_battery_status_available(bool value) { 51 void set_battery_status_available(bool value) {
51 battery_status_available_ = value; 52 battery_status_available_ = value;
52 } 53 }
53 54
54 bool started() { 55 bool started() { return started_; }
55 return started_;
56 }
57 56
58 private: 57 private:
59 device::BatteryStatusService::BatteryUpdateCallback callback_; 58 device::BatteryStatusService::BatteryUpdateCallback callback_;
60 bool battery_status_available_; 59 bool battery_status_available_;
61 bool started_; 60 bool started_;
62 device::BatteryStatus status_; 61 device::BatteryStatus status_;
63 62
64 DISALLOW_COPY_AND_ASSIGN(FakeBatteryManager); 63 DISALLOW_COPY_AND_ASSIGN(FakeBatteryManager);
65 }; 64 };
66 65
67 class BatteryStatusBrowserTest : public ContentBrowserTest { 66 class BatteryMonitorImplTest : public ContentBrowserTest {
68 public: 67 public:
69 BatteryStatusBrowserTest() 68 BatteryMonitorImplTest() : battery_manager_(NULL), battery_service_(NULL) {}
70 : battery_manager_(NULL),
71 battery_service_(NULL) {
72 }
73
74 void SetUpCommandLine(CommandLine* command_line) override {
75 command_line->AppendSwitch(
76 switches::kEnableExperimentalWebPlatformFeatures);
77 }
78 69
79 void SetUpOnMainThread() override { 70 void SetUpOnMainThread() override {
80 battery_service_ = device::BatteryStatusService::GetInstance(); 71 battery_service_ = device::BatteryStatusService::GetInstance();
81 72
82 // We keep a raw pointer to the FakeBatteryManager, which we expect to 73 // We keep a raw pointer to the FakeBatteryManager, which we expect to
83 // remain valid for the lifetime of the BatteryStatusService. 74 // remain valid for the lifetime of the BatteryStatusService.
84 scoped_ptr<FakeBatteryManager> battery_manager(new FakeBatteryManager( 75 scoped_ptr<FakeBatteryManager> battery_manager(new FakeBatteryManager(
85 battery_service_->GetUpdateCallbackForTesting())); 76 battery_service_->GetUpdateCallbackForTesting()));
86 battery_manager_ = battery_manager.get(); 77 battery_manager_ = battery_manager.get();
87 78
88 battery_service_->SetBatteryManagerForTesting( 79 battery_service_->SetBatteryManagerForTesting(battery_manager.Pass());
89 battery_manager.Pass());
90 } 80 }
91 81
92 void TearDown() override { 82 void TearDown() override {
93 battery_service_->SetBatteryManagerForTesting( 83 battery_service_->SetBatteryManagerForTesting(
94 scoped_ptr<device::BatteryStatusManager>()); 84 scoped_ptr<device::BatteryStatusManager>());
95 battery_manager_ = NULL; 85 battery_manager_ = NULL;
96 } 86 }
97 87
98 FakeBatteryManager* battery_manager() { 88 FakeBatteryManager* battery_manager() { return battery_manager_; }
99 return battery_manager_;
100 }
101 89
102 private: 90 private:
103 FakeBatteryManager* battery_manager_; 91 FakeBatteryManager* battery_manager_;
104 device::BatteryStatusService* battery_service_; 92 device::BatteryStatusService* battery_service_;
105 93
106 DISALLOW_COPY_AND_ASSIGN(BatteryStatusBrowserTest); 94 DISALLOW_COPY_AND_ASSIGN(BatteryMonitorImplTest);
107 }; 95 };
108 96
109 IN_PROC_BROWSER_TEST_F(BatteryStatusBrowserTest, BatteryManagerDefaultValues) { 97 IN_PROC_BROWSER_TEST_F(BatteryMonitorImplTest, BatteryManagerDefaultValues) {
110 // Set the fake battery manager to return false on start. From JavaScript 98 // Set the fake battery manager to return false on start. From JavaScript
111 // request a promise for the battery status information and once it resolves 99 // request a promise for the battery status information and once it resolves
112 // check the default values and navigate to #pass. 100 // check the default values and navigate to #pass.
113 battery_manager()->set_battery_status_available(false); 101 battery_manager()->set_battery_status_available(false);
114 GURL test_url = GetTestUrl( 102 GURL test_url =
115 "battery_status", "battery_status_default_test.html"); 103 GetTestUrl("battery_status", "battery_status_default_test.html");
116 NavigateToURLBlockUntilNavigationsComplete(shell(), test_url, 2); 104 NavigateToURLBlockUntilNavigationsComplete(shell(), test_url, 2);
117 EXPECT_EQ("pass", shell()->web_contents()->GetLastCommittedURL().ref()); 105 EXPECT_EQ("pass", shell()->web_contents()->GetLastCommittedURL().ref());
118 EXPECT_TRUE(battery_manager()->started()); 106 EXPECT_TRUE(battery_manager()->started());
119 } 107 }
120 108
121 IN_PROC_BROWSER_TEST_F(BatteryStatusBrowserTest, BatteryManagerResolvePromise) { 109 IN_PROC_BROWSER_TEST_F(BatteryMonitorImplTest, BatteryManagerResolvePromise) {
122 // Set the fake battery manager to return predefined battery status values. 110 // Set the fake battery manager to return predefined battery status values.
123 // From JavaScript request a promise for the battery status information and 111 // From JavaScript request a promise for the battery status information and
124 // once it resolves check the values and navigate to #pass. 112 // once it resolves check the values and navigate to #pass.
125 device::BatteryStatus status; 113 device::BatteryStatus status;
126 status.charging = true; 114 status.charging = true;
127 status.charging_time = 100; 115 status.charging_time = 100;
128 status.discharging_time = std::numeric_limits<double>::infinity(); 116 status.discharging_time = std::numeric_limits<double>::infinity();
129 status.level = 0.5; 117 status.level = 0.5;
130 battery_manager()->set_battery_status(status); 118 battery_manager()->set_battery_status(status);
131 119
132 GURL test_url = GetTestUrl( 120 GURL test_url = GetTestUrl("battery_status",
133 "battery_status", "battery_status_promise_resolution_test.html"); 121 "battery_status_promise_resolution_test.html");
134 NavigateToURLBlockUntilNavigationsComplete(shell(), test_url, 2); 122 NavigateToURLBlockUntilNavigationsComplete(shell(), test_url, 2);
135 EXPECT_EQ("pass", shell()->web_contents()->GetLastCommittedURL().ref()); 123 EXPECT_EQ("pass", shell()->web_contents()->GetLastCommittedURL().ref());
136 EXPECT_TRUE(battery_manager()->started()); 124 EXPECT_TRUE(battery_manager()->started());
137 } 125 }
138 126
139 IN_PROC_BROWSER_TEST_F(BatteryStatusBrowserTest, 127 IN_PROC_BROWSER_TEST_F(BatteryMonitorImplTest,
140 BatteryManagerWithEventListener) { 128 BatteryManagerWithEventListener) {
141 // Set the fake battery manager to return default battery status values. 129 // Set the fake battery manager to return default battery status values.
142 // From JavaScript request a promise for the battery status information. 130 // From JavaScript request a promise for the battery status information.
143 // Once it resolves add an event listener for battery level change. Set 131 // Once it resolves add an event listener for battery level change. Set
144 // battery level to 0.6 and invoke update. Check that the event listener 132 // battery level to 0.6 and invoke update. Check that the event listener
145 // is invoked with the correct value for level and navigate to #pass. 133 // is invoked with the correct value for level and navigate to #pass.
146 device::BatteryStatus status; 134 device::BatteryStatus status;
147 battery_manager()->set_battery_status(status); 135 battery_manager()->set_battery_status(status);
148 136
149 TestNavigationObserver same_tab_observer(shell()->web_contents(), 2); 137 TestNavigationObserver same_tab_observer(shell()->web_contents(), 2);
150 GURL test_url = GetTestUrl( 138 GURL test_url =
151 "battery_status", "battery_status_event_listener_test.html"); 139 GetTestUrl("battery_status", "battery_status_event_listener_test.html");
152 shell()->LoadURL(test_url); 140 shell()->LoadURL(test_url);
153 same_tab_observer.Wait(); 141 same_tab_observer.Wait();
154 EXPECT_EQ("resolved", shell()->web_contents()->GetLastCommittedURL().ref()); 142 EXPECT_EQ("resolved", shell()->web_contents()->GetLastCommittedURL().ref());
155 143
156 TestNavigationObserver same_tab_observer2(shell()->web_contents(), 1); 144 TestNavigationObserver same_tab_observer2(shell()->web_contents(), 1);
157 status.level = 0.6; 145 status.level = 0.6;
158 battery_manager()->set_battery_status(status); 146 battery_manager()->set_battery_status(status);
159 battery_manager()->InvokeUpdateCallback(); 147 battery_manager()->InvokeUpdateCallback();
160 same_tab_observer2.Wait(); 148 same_tab_observer2.Wait();
161 EXPECT_EQ("pass", shell()->web_contents()->GetLastCommittedURL().ref()); 149 EXPECT_EQ("pass", shell()->web_contents()->GetLastCommittedURL().ref());
162 EXPECT_TRUE(battery_manager()->started()); 150 EXPECT_TRUE(battery_manager()->started());
163 } 151 }
164 152
165 } // namespace 153 } // namespace
166 154
167 } // namespace content 155 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | content/browser/battery_status/battery_monitor_integration_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698