cc/PRESUBMIT.py - Issue 734063004: Update from https://crrev.com/304418

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/PRESUBMIT.py

Issue 734063004: Update from https://crrev.com/304418 (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/PRESUBMIT.py

diff --git a/cc/PRESUBMIT.py b/cc/PRESUBMIT.py

index 46c3a54349e54bd37d9ea158d7646c9c96b610d5..71c4ea1f1f635c299524eea77c4787a3037ef4fe 100644

--- a/cc/PRESUBMIT.py

+++ b/cc/PRESUBMIT.py

@@ -11,7 +11,7 @@ for more details about the presubmit API built into depot_tools.

import re

import string

-CC_SOURCE_FILES=(r'^cc/.*\.(cc|h)$',)

+CC_SOURCE_FILES=(r'^cc/.*\.(cc|h)$', r'^cc\\.*\.(cc|h)$')

def CheckChangeLintsClean(input_api, output_api):

input_api.cpplint._cpplint_state.ResetErrorCounts() # reset global state

@@ -21,10 +21,6 @@ def CheckChangeLintsClean(input_api, output_api):

input_api.AffectedSourceFiles(source_filter)]

level = 1 # strict, but just warn

- # TODO(danakj): Temporary, while the OVERRIDE and FINAL fixup is in progress.

- # crbug.com/422353

- input_api.cpplint._SetFilters('-readability/inheritance')

for file_name in files:

input_api.cpplint.ProcessFile(file_name, level)

« no previous file with comments | « cc/BUILD.gn ('k') | cc/base/delayed_unique_notifier_unittest.cc » ('j') | no next file with comments »