OLD | NEW |
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
4 | 4 |
5 """Top-level presubmit script for cc. | 5 """Top-level presubmit script for cc. |
6 | 6 |
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
8 for more details about the presubmit API built into depot_tools. | 8 for more details about the presubmit API built into depot_tools. |
9 """ | 9 """ |
10 | 10 |
11 import re | 11 import re |
12 import string | 12 import string |
13 | 13 |
14 CC_SOURCE_FILES=(r'^cc/.*\.(cc|h)$',) | 14 CC_SOURCE_FILES=(r'^cc/.*\.(cc|h)$', r'^cc\\.*\.(cc|h)$') |
15 | 15 |
16 def CheckChangeLintsClean(input_api, output_api): | 16 def CheckChangeLintsClean(input_api, output_api): |
17 input_api.cpplint._cpplint_state.ResetErrorCounts() # reset global state | 17 input_api.cpplint._cpplint_state.ResetErrorCounts() # reset global state |
18 source_filter = lambda x: input_api.FilterSourceFile( | 18 source_filter = lambda x: input_api.FilterSourceFile( |
19 x, white_list=CC_SOURCE_FILES, black_list=None) | 19 x, white_list=CC_SOURCE_FILES, black_list=None) |
20 files = [f.AbsoluteLocalPath() for f in | 20 files = [f.AbsoluteLocalPath() for f in |
21 input_api.AffectedSourceFiles(source_filter)] | 21 input_api.AffectedSourceFiles(source_filter)] |
22 level = 1 # strict, but just warn | 22 level = 1 # strict, but just warn |
23 | 23 |
24 # TODO(danakj): Temporary, while the OVERRIDE and FINAL fixup is in progress. | |
25 # crbug.com/422353 | |
26 input_api.cpplint._SetFilters('-readability/inheritance') | |
27 | |
28 for file_name in files: | 24 for file_name in files: |
29 input_api.cpplint.ProcessFile(file_name, level) | 25 input_api.cpplint.ProcessFile(file_name, level) |
30 | 26 |
31 if not input_api.cpplint._cpplint_state.error_count: | 27 if not input_api.cpplint._cpplint_state.error_count: |
32 return [] | 28 return [] |
33 | 29 |
34 return [output_api.PresubmitPromptWarning( | 30 return [output_api.PresubmitPromptWarning( |
35 'Changelist failed cpplint.py check.')] | 31 'Changelist failed cpplint.py check.')] |
36 | 32 |
37 def CheckAsserts(input_api, output_api, white_list=CC_SOURCE_FILES, black_list=N
one): | 33 def CheckAsserts(input_api, output_api, white_list=CC_SOURCE_FILES, black_list=N
one): |
(...skipping 302 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
340 results += FindUselessIfdefs(input_api, output_api) | 336 results += FindUselessIfdefs(input_api, output_api) |
341 results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api) | 337 results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api) |
342 return results | 338 return results |
343 | 339 |
344 def GetPreferredTryMasters(project, change): | 340 def GetPreferredTryMasters(project, change): |
345 return { | 341 return { |
346 'tryserver.blink': { | 342 'tryserver.blink': { |
347 'linux_blink_rel': set(['defaulttests']), | 343 'linux_blink_rel': set(['defaulttests']), |
348 }, | 344 }, |
349 } | 345 } |
OLD | NEW |