Issue 734053006: Subzero: Use std::vector<> instead of std::list for live range segments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 734053006: Subzero: Use std::vector<> instead of std::list for live range segments. (Closed)

Created:
6 years ago by Jim Stichnoth

Modified:
6 years ago

Reviewers:
jvoung (off chromium)

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Visibility:
Public.

Subzero: Use std::vector<> instead of std::list for live range segments. This generally uses less memory and fewer allocations. Also removes the commented-out alternative implementation using std::set<>, which would almost certainly never be a good idea here. BUG= none R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=2a7fcbb4aa216dc4db4216a5275a3471da25f7c5

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -48 lines)			Patch
M	src/IceDefs.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/IceOperand.h	View	2 chunks	+8 lines, -11 lines	0 comments	Download
M	src/IceOperand.cpp	View	3 chunks	+4 lines, -33 lines	0 comments	Download
M	src/IceRegAlloc.cpp	View	1 chunk	+1 line, -3 lines	0 comments	Download

Total messages: 4 (1 generated)

Jim Stichnoth

6 years ago (2014-12-04 19:45:10 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2a7fcbb4aa216dc4db4216a5275a3471da25f7c5 (tree was closed).