Reporting of policy errors via host-offline-reason: part 2b

remoting/host/heartbeat_sender.h

Index: remoting/host/heartbeat_sender.h
diff --git a/remoting/host/heartbeat_sender.h b/remoting/host/heartbeat_sender.h
index e816f9c75e9608f0571588ca0350ffc30957e88d..1d15aa53343482d428a0ec647b1ac1ed4e978b0c 100644
--- a/remoting/host/heartbeat_sender.h
+++ b/remoting/host/heartbeat_sender.h
@@ -7,6 +7,7 @@
 
 #include <string>
 
+#include "base/callback.h"

[Lambros, 2014/11/18 02:33:52]

callback_forward.h :)

[Łukasz Anforowicz, 2014/11/18 17:30:45]

What about the base::Closure by-value / not-a-pointer-or-reference fields being
added below?  (I wish Rietveld would show line numbers so I can more easily
refer to other parts of the code being reviewed :-/).

[Lambros, 2014/11/18 18:47:21]

Yes you're right, didn't see those. I only scanned for "Callback" :)

 #include "base/compiler_specific.h"
 #include "base/gtest_prod_util.h"
 #include "base/memory/ref_counted.h"
@@ -87,21 +88,11 @@ class IqSender;
 //  </iq>
 class HeartbeatSender : public SignalStrategy::Listener {
  public:
-  class Listener {
-   public:
-    virtual ~Listener() { }
-
-    // Invoked after the first successful heartbeat.
-    virtual void OnHeartbeatSuccessful() = 0;
-
-    // Invoked when the host ID is permanently not recognized by the server.
-    virtual void OnUnknownHostIdError() = 0;
-  };
-
   // |signal_strategy| and |delegate| must outlive this
   // object. Heartbeats will start when the supplied SignalStrategy
   // enters the CONNECTED state.
-  HeartbeatSender(Listener* listener,
+  HeartbeatSender(const base::Closure& on_heartbeat_successful_callback,
+                  const base::Closure& on_unknown_host_id_error,
                   const std::string& host_id,
                   SignalStrategy* signal_strategy,
                   scoped_refptr<RsaKeyPair> key_pair,
@@ -147,7 +138,8 @@ class HeartbeatSender : public SignalStrategy::Listener {
   scoped_ptr<buzz::XmlElement> CreateHeartbeatMessage();
   scoped_ptr<buzz::XmlElement> CreateSignature();
 
-  Listener* listener_;
+  base::Closure on_heartbeat_successful_callback_;
+  base::Closure on_unknown_host_id_error_;
   std::string host_id_;
   SignalStrategy* signal_strategy_;
   scoped_refptr<RsaKeyPair> key_pair_;
@@ -164,14 +156,6 @@ class HeartbeatSender : public SignalStrategy::Listener {
   int failed_startup_heartbeat_count_;
   std::string host_offline_reason_;
   base::Closure host_offline_reason_ack_callback_;
-  // TODO(lukasza): Consistent usage of listener-vs-callback. This is
-  // inconsistent today, because 1) host-offline-reason changes really
-  // needed to use callbacks (for ability to wrap them in
-  // CancellableCallback and for ability to hold a ref-count to
-  // MinimumHeartbeatSupporter throughout the lifetime of a callback)
-  // and 2) refactoring for consistently using callbacks everywhere
-  // spans multiple files and would obscure the core changes for
-  // host-offline-reason code.
 
   base::ThreadChecker thread_checker_;