Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 734033004: libc++: fix the traps numeric_limits test (Closed)

Created:
6 years, 1 month ago by JF
Modified:
6 years, 1 month ago
Reviewers:
Derek Schuff
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-libcxx.git@master
Visibility:
Public.

Description

libc++: fix the traps numeric_limits test We have a localmod in <limits> but not in the test. I'll update libcxx_known_failures.txt with the LLVM 3.5 roll, and update COMPONENT_REVISIONS at the same time. R=dschuff@chromium.org BUG= https://code.google.com/p/nativeclient/issues/detail?id=3930 TEST= ./pnacl/scripts/llvm-test.py --libcxx-tests Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-libcxx.git;a=commit;h=ba6de7e3eaac146ce1553c4b28141c19246c50e9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/language.support/support.limits/limits/numeric.limits.members/traps.pass.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
JF
6 years, 1 month ago (2014-11-18 00:57:55 UTC) #1
Derek Schuff
lgtm
6 years, 1 month ago (2014-11-18 00:58:33 UTC) #2
JF
6 years, 1 month ago (2014-11-18 00:58:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ba6de7e3eaac146ce1553c4b28141c19246c50e9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698