Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 734033003: Enabling the "enable offline load stale cache" flag for ChromeOS (Closed)

Created:
6 years, 1 month ago by afakhry
Modified:
6 years, 1 month ago
Reviewers:
Jun Mukai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Enabling the "enable offline load stale cache" flag for ChromeOS R=mukai@chromium.org BUG=433388 TEST=manual Committed: https://crrev.com/f0227a0e8e391c8ebffd04e1164285febf5f9374 Cr-Commit-Position: refs/heads/master@{#304513}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/about_flags.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
afakhry
6 years, 1 month ago (2014-11-17 19:44:47 UTC) #1
Jun Mukai
https://codereview.chromium.org/734033003/diff/1/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (right): https://codereview.chromium.org/734033003/diff/1/chrome/browser/about_flags.cc#newcode1298 chrome/browser/about_flags.cc:1298: kOsLinux | kOsMac | kOsWin | kOsAndroid | kOsCrOS, ...
6 years, 1 month ago (2014-11-17 20:10:47 UTC) #2
afakhry
https://codereview.chromium.org/734033003/diff/1/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (right): https://codereview.chromium.org/734033003/diff/1/chrome/browser/about_flags.cc#newcode1298 chrome/browser/about_flags.cc:1298: kOsLinux | kOsMac | kOsWin | kOsAndroid | kOsCrOS, ...
6 years, 1 month ago (2014-11-17 22:05:50 UTC) #3
Jun Mukai
lgtm
6 years, 1 month ago (2014-11-17 22:07:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/734033003/20001
6 years, 1 month ago (2014-11-17 22:10:30 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-17 23:12:50 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-17 23:14:22 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f0227a0e8e391c8ebffd04e1164285febf5f9374
Cr-Commit-Position: refs/heads/master@{#304513}

Powered by Google App Engine
This is Rietveld 408576698